From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, "Major Dávid" <major.david@balasys.hu>
Subject: Re: [PATCH nf] netfilter: tproxy: fix deadlock due to missing BH disable
Date: Mon, 6 Mar 2023 12:10:47 +0100 [thread overview]
Message-ID: <ZAXKN/qGNssc93ST@salvia> (raw)
In-Reply-To: <20230303095856.30402-1-fw@strlen.de>
On Fri, Mar 03, 2023 at 10:58:56AM +0100, Florian Westphal wrote:
> The xtables packet traverser performs an unconditional local_bh_disable(),
> but the nf_tables evaluation loop does not.
>
> Functions that are called from either xtables or nftables must assume
> that they can be called in process context.
>
> inet_twsk_deschedule_put() assumes that no softirq interrupt can occur.
> If tproxy is used from nf_tables its possible that we'll deadlock
> trying to aquire a lock already held in process context.
>
> Add a small helper that takes care of this and use it.
Applied, thanks
prev parent reply other threads:[~2023-03-06 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 9:58 [PATCH nf] netfilter: tproxy: fix deadlock due to missing BH disable Florian Westphal
2023-03-06 11:10 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAXKN/qGNssc93ST@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=major.david@balasys.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.