From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pin-yen Lin <treapking@chromium.org>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Prashant Malani" <pmalani@chromium.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Xin Ji" <xji@analogixsemi.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Lyude Paul" <lyude@redhat.com>,
linux-kernel@vger.kernel.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
chrome-platform@lists.linux.dev,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Marek Vasut" <marex@denx.de>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
devicetree@vger.kernel.org, "Allen Chen" <allen.chen@ite.com.tw>,
dri-devel@lists.freedesktop.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Stephen Boyd" <swboyd@chromium.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches
Date: Mon, 6 Mar 2023 13:55:24 +0200 [thread overview]
Message-ID: <ZAXUrJDtHmm7+50H@smile.fi.intel.com> (raw)
In-Reply-To: <20230303143350.815623-8-treapking@chromium.org>
On Fri, Mar 03, 2023 at 10:33:47PM +0800, Pin-yen Lin wrote:
> Register USB Type-C mode switches when the "mode-switch" property and
> relevant ports are available in Device Tree. Configure the crosspoint
> switch based on the entered alternate mode for a specific Type-C
> connector.
>
> Crosspoint switch can also be used for switching the output signal for
> different orientations of a single USB Type-C connector, but the
> orientation switch is not implemented yet. A TODO is added for this.
...
> + ctx->port_data = devm_kcalloc(
> + dev, switch_desc->num_typec_switches,
> + sizeof(struct anx7625_typec_port_data), GFP_KERNEL);
I believe I have commented on this (indentation)...
> +
...and this (blank line).
> + if (!ctx->port_data) {
> + ret = -ENOMEM;
> + goto unregister_mux;
> + }
...
> + ctx->port_data[i].orientation = (dp_lanes[0] / 2 == 0) ?
> + TYPEC_ORIENTATION_REVERSE : TYPEC_ORIENTATION_NORMAL;
I believe that this is an error prone check, you should rather do the opposite,
i.e. ' % 2 == 0'.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pin-yen Lin <treapking@chromium.org>
Cc: "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
dri-devel@lists.freedesktop.org,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Marek Vasut" <marex@denx.de>,
chrome-platform@lists.linux.dev, "Robert Foss" <rfoss@kernel.org>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Allen Chen" <allen.chen@ite.com.tw>,
"Stephen Boyd" <swboyd@chromium.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Xin Ji" <xji@analogixsemi.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Daniel Scally" <djrscally@gmail.com>,
"Prashant Malani" <pmalani@chromium.org>
Subject: Re: [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches
Date: Mon, 6 Mar 2023 13:55:24 +0200 [thread overview]
Message-ID: <ZAXUrJDtHmm7+50H@smile.fi.intel.com> (raw)
In-Reply-To: <20230303143350.815623-8-treapking@chromium.org>
On Fri, Mar 03, 2023 at 10:33:47PM +0800, Pin-yen Lin wrote:
> Register USB Type-C mode switches when the "mode-switch" property and
> relevant ports are available in Device Tree. Configure the crosspoint
> switch based on the entered alternate mode for a specific Type-C
> connector.
>
> Crosspoint switch can also be used for switching the output signal for
> different orientations of a single USB Type-C connector, but the
> orientation switch is not implemented yet. A TODO is added for this.
...
> + ctx->port_data = devm_kcalloc(
> + dev, switch_desc->num_typec_switches,
> + sizeof(struct anx7625_typec_port_data), GFP_KERNEL);
I believe I have commented on this (indentation)...
> +
...and this (blank line).
> + if (!ctx->port_data) {
> + ret = -ENOMEM;
> + goto unregister_mux;
> + }
...
> + ctx->port_data[i].orientation = (dp_lanes[0] / 2 == 0) ?
> + TYPEC_ORIENTATION_REVERSE : TYPEC_ORIENTATION_NORMAL;
I believe that this is an error prone check, you should rather do the opposite,
i.e. ' % 2 == 0'.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-06 11:55 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 14:33 [PATCH v13 00/10] Register Type-C mode-switch in DP bridge endpoints Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 01/10] device property: Add remote endpoint to devcon matcher Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-06 11:43 ` Andy Shevchenko
2023-03-06 11:43 ` Andy Shevchenko
2023-03-06 11:54 ` Sakari Ailus
2023-03-06 11:54 ` Sakari Ailus
2023-03-08 7:30 ` Heikki Krogerus
2023-03-08 7:30 ` Heikki Krogerus
2023-03-03 14:33 ` [PATCH v13 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 03/10] drm/display: Add Type-C switch helpers Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-06 11:49 ` Andy Shevchenko
2023-03-06 11:49 ` Andy Shevchenko
2023-03-08 10:20 ` Pin-yen Lin
2023-03-08 10:20 ` Pin-yen Lin
2023-03-08 15:28 ` Andy Shevchenko
2023-03-08 15:28 ` Andy Shevchenko
2023-03-09 10:20 ` Pin-yen Lin
2023-03-09 10:20 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 05/10] drm/bridge: anx7625: Check for Type-C during panel registration Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-06 11:51 ` Andy Shevchenko
2023-03-06 11:51 ` Andy Shevchenko
2023-03-08 10:25 ` Pin-yen Lin
2023-03-08 10:25 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505 Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-06 11:55 ` Andy Shevchenko [this message]
2023-03-06 11:55 ` Andy Shevchenko
2023-03-08 13:44 ` Pin-yen Lin
2023-03-08 13:44 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 09/10] drm/bridge: it6505: Fix Kconfig indentation Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches Pin-yen Lin
2023-03-03 14:33 ` Pin-yen Lin
2023-03-04 10:26 ` kernel test robot
2023-03-06 12:02 ` Andy Shevchenko
2023-03-06 12:02 ` Andy Shevchenko
2023-03-08 13:51 ` Pin-yen Lin
2023-03-08 13:51 ` Pin-yen Lin
2023-03-08 15:31 ` Andy Shevchenko
2023-03-08 15:31 ` Andy Shevchenko
2023-03-09 10:21 ` Pin-yen Lin
2023-03-09 10:21 ` Pin-yen Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAXUrJDtHmm7+50H@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=allen.chen@ite.com.tw \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.