From: Heiko Carstens <hca@linux.ibm.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: trim ancient junk from copy_thread()
Date: Mon, 6 Mar 2023 15:02:02 +0100 [thread overview]
Message-ID: <ZAXyWqNMlftSJfPh@osiris> (raw)
In-Reply-To: <ZAU6BYFisE8evmYf@ZenIV>
On Mon, Mar 06, 2023 at 12:55:33AM +0000, Al Viro wrote:
> Setting and ->psw.addr in childregs of kernel thread is a rudiment of
> the old kernel_thread()/kernel_execve() implementation. Mainline hadn't
> been using them since 2012.
>
> And clarify the assigments to frame->sf.gprs - the array stores grp6..gpr15
> values to be set by __switch_to(), so frame->sf.gprs[5] actually affects
> grp11, etc. Better spell that as frame->sf.gprs[11 - 6]...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
> index 67df64ef4839..87ca3a727604 100644
> --- a/arch/s390/kernel/process.c
> +++ b/arch/s390/kernel/process.c
Applied, thanks!
prev parent reply other threads:[~2023-03-06 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 0:55 [PATCH] s390: trim ancient junk from copy_thread() Al Viro
2023-03-06 14:02 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAXyWqNMlftSJfPh@osiris \
--to=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.