From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 269CEC678D4 for ; Tue, 7 Mar 2023 12:40:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZWcU-0003fx-MM; Tue, 07 Mar 2023 07:40:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZWcI-0003bA-AH for qemu-devel@nongnu.org; Tue, 07 Mar 2023 07:40:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZWcG-0002el-Es for qemu-devel@nongnu.org; Tue, 07 Mar 2023 07:40:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678192827; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Q2aI9l2d5Qcggw0WjNsjMcQL+WulfjfqmiTBqeTDx4=; b=e1b7pWbRc4zgu8lK0v3U5ICEv2RfGFHbOL06HVrRv9UL9xfWbDAcVlIQjTcTdOIEWSZF45 Q2iinthJ277BkBUitg1P0AozfVUW7r0Lzjrgf71AfqJGq01SAH+IH2MJ/PlD1FOXp6Rig+ zZ214dPCcdRqzRDpMEw0e3sBhXAGPOM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-99-SM4E9YRGMs2p6lYSezpNFQ-1; Tue, 07 Mar 2023 07:40:26 -0500 X-MC-Unique: SM4E9YRGMs2p6lYSezpNFQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5614C3C1485F for ; Tue, 7 Mar 2023 12:40:26 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4779818EC6; Tue, 7 Mar 2023 12:40:25 +0000 (UTC) Date: Tue, 7 Mar 2023 12:40:22 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, armbru@redhat.com Subject: Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files Message-ID: References: <20230307123027.2485499-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230307123027.2485499-1-marcandre.lureau@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 07, 2023 at 04:30:27PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > This seems to be the preferred style. > > The EditorConfig property is not supported by all editors: > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length > > Signed-off-by: Marc-André Lureau > --- > .editorconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.editorconfig b/.editorconfig > index 7303759ed7..8c5ebc6a1b 100644 > --- a/.editorconfig > +++ b/.editorconfig > @@ -47,3 +47,4 @@ emacs_mode = glsl > [*.json] > indent_style = space > emacs_mode = python > +max_line_length = 70 Why 70 as a hard limit ? I thought QEMU policy was that 80 was a soft limit and we were happy with 90 if it avoided wrapping that would hurt readability. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|