From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFB82AD49 for ; Tue, 7 Mar 2023 16:09:02 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-53865bdc1b1so140994067b3.16 for ; Tue, 07 Mar 2023 08:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678205341; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=F/kB0IypJg6aZTqiDMRZ19llJnUhGLwpqU6UaEdUNes=; b=Qcv9UAxgt3xsVviKCRDvfMjfSgCYyxThyJGUY1uqeSnXtz2UObx094Vce9b2Sjr0vO rZfRWAve4F+sOI/kLHx3odrPVjgMDXWP35fXk5n1l9aOU2uIfHqByiMqkq7HSmz36s8S Ry20+D8/KTN8vxqL783LbfpBBCErpSjNNZyuJGb9ZBkimBaGSQYcnFRb6TIz8Vw0ViDY tYgvEj3YZUTsjHevcqe4fyqrGGhIfR8AL1vfxndlyfXrDW5BYdt2Lha0/cSM149UKLgt BRneD96KqX1yJz9SkiYDDfefLf59pbsFXmMycCg1pu22Nmt2iVGJPrx8KLT98QHVOT0o qsOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678205342; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=F/kB0IypJg6aZTqiDMRZ19llJnUhGLwpqU6UaEdUNes=; b=kpnifQwymLOXXrTFca5HF4f+yx8coBGPFpdcfFA4dar1ahm3Jt9y3RHKqFpTnITpdb TfA3LqWoZD64Fn3/3C1nEsk/tR1HehupkuYYN8f+RpSs0CNO9zLjzgcLEW8YahGEMo4z 7W91POV8N1woLruNhFkyobyEo4aHRv7C1LQKr5kg/5ZRg2Z8EOp90JkRpiLRkfNcPgKF 4r+hTlCSt2VbPHs8seb+hgXqLQLZpaLDwo4e3SDSZIxeMNPuYemKtNtggjaGuQaG5g5v /8KcSMp8UzFVnWhdunJmbBR4RuxrQ1WJ+t0x2B32zffyEmn5MQBjVvEouXS0WtltfIDb bWDQ== X-Gm-Message-State: AO0yUKUauZqApQdj3e79yyUUsNoWoxlszCtqEtnPHP+u4h45g6XEy4NQ b8WDOtlvJkHwS97MefpmIT03nsF0mLo= X-Google-Smtp-Source: AK7set/VaM/tRd87+KvjpO4jP7xvodLAwtiDafs6T4TQLSxQiVQL+0JvQJwZHuvJg43BGTQ4mobDppzr77s= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:b71c:0:b0:536:7529:55b4 with SMTP id v28-20020a81b71c000000b00536752955b4mr9597369ywh.3.1678205341764; Tue, 07 Mar 2023 08:09:01 -0800 (PST) Date: Tue, 7 Mar 2023 08:09:00 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230215010717.3612794-1-rananta@google.com> <20230215010717.3612794-11-rananta@google.com> Message-ID: Subject: Re: [REPOST PATCH 10/16] selftests: KVM: aarch64: Add KVM EVTYPE filter PMU test From: Sean Christopherson To: Reiji Watanabe Cc: Raghavendra Rao Ananta , Oliver Upton , Marc Zyngier , Ricardo Koller , James Morse , Suzuki K Poulose , Paolo Bonzini , Jing Zhang , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable RESEND is the "standard" tag, not REPOST. On Mon, Mar 06, 2023, Reiji Watanabe wrote: > Hi Raghu, >=20 > On Tue, Feb 14, 2023 at 5:07=E2=80=AFPM Raghavendra Rao Ananta > wrote: > > > > KVM doest't allow the guests to modify the filter types > > such counting events in nonsecure/secure-EL2, EL3, and > > so on. Validate the same by force-configuring the bits > > in PMXEVTYPER_EL0, PMEVTYPERn_EL0, and PMCCFILTR_EL0 > > registers. > > > > The test extends further by trying to create an event > > for counting only in EL2 and validates if the counter > > is not progressing. > > > > Signed-off-by: Raghavendra Rao Ananta > > --- > > +static void guest_evtype_filter_test(void) > > +{ > > + int i; > > + struct pmc_accessor *acc; > > + uint64_t typer, cnt; > > + struct arm_smccc_res res; > > + > > + pmu_enable(); > > + > > + /* > > + * KVM blocks the guests from creating events for counting in S= ecure/Non-Secure Hyp (EL2), > > + * Monitor (EL3), and Multithreading configuration. It applies = the mask > > + * ARMV8_PMU_EVTYPE_MASK against guest accesses to PMXEVTYPER_E= L0, PMEVTYPERn_EL0, > > + * and PMCCFILTR_EL0 registers to prevent this. Check if KVM ho= nors this using all possible > > + * ways to configure the EVTYPER. > > + */ >=20 > I would prefer to break long lines into multiple lines for these comments > (or other comments in these patches), as "Linux kernel coding style" > suggests. +1. And on the other side of the coin, wrap the changelog closer to ~75 ch= ars, ~54 chars is waaay too aggressive. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CCD1C678D5 for ; Tue, 7 Mar 2023 16:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7MrJJL5ycrewwRrDzClaaKcSA6bE5fACdouPyy1R1IE=; b=n9Q1fwi+LTgBmTHaQU8VYMuJ53 occR0RdXWG7vIO0T/a7tbpKYGRMO+isGIBslRqupiwLE5o3iEmtMSE63LgQ00vUoo5aDrlLqcHzqY au0XYUldIT5CUxMXkoHFimyx0V7JhhF1dbuqXjkd4F0WoQyBHK34aZfgPR0WsDsL1s7y8A3RwVBsS JCDbPoGRQNiMcBbOZcEy9aPeS7F2/0NluA6crD1qq6By7j2IWaLbfmjvPUdz12WTz9ckjREZzansX n9LdupKQK4lAHN9SrzId3i7Oh7VQFha/lrmNid91KVZhdG7jbYYPoWcIuM4Gz7fLd7TLoUdNDpJyH rpMXxDWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZZsE-001RYX-64; Tue, 07 Mar 2023 16:09:10 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZZsA-001RW0-53 for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 16:09:07 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-536bf649e70so140291087b3.0 for ; Tue, 07 Mar 2023 08:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678205342; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=F/kB0IypJg6aZTqiDMRZ19llJnUhGLwpqU6UaEdUNes=; b=USQiwWAU795XSJHQGI4V/FSuFe5C45hnKLi6dApc6pjMxxt2/eqxaG+y8KIN4/+mrj qATRXxqyWqVh46hzg7S+3NzZbpG7fzdG6VQEYHMKZTaDvksW6YktldoP8/JpxV3txaNl Mcm3tmxAXr2OQ5ajxpg3YxGI6A+1Vfb53v6aUEUSjfLLE8tSA4tF+luVHYshQ11bC3Se qrFHzcjq4JBPHInv0OiLQW2D4ZVn7/Den6TQqxeeQ7xd8ZOMW6iMvjO9ptI0stfBmlpa WseV54lf4IN56SyJDJ3MjU19pwbYMR5+mLepy0HTJFHkA/46MWpBbKBWTmnW8kaeW4+u F2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678205342; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=F/kB0IypJg6aZTqiDMRZ19llJnUhGLwpqU6UaEdUNes=; b=VDyasK0CvYx0Z88KzMHNUTQEM8T8aJgmeItztSLRDbHR6g5JJ7+zQjsSUdcD4kMkC6 FQXltJyWAbKI+4uwGDSKDwlXCI4gQPqeN2i6EBvMrONwaU8zTAguaX+bEPxwe46DXAxc 7gdY/mMNY8lLW15Vm6a5OpxGWxd0F0ckaJUCnDSjzN2heX2wzsMxyn/011/nWvbUQ7mL QRHeb4LOdWk/3w5dM/WW+SLeUhvSkTYkXTmnDYbb+hf7pSrOH6JKFIFA4r343b/WVcfJ VPVW//Ns0Ltx7a5fvDBrYHF1N8XqRJsnftTJ86OBqsTONA58qUHsIIZYUy/GNeAolVA4 XLaA== X-Gm-Message-State: AO0yUKVzqiTWCOTnigSu9Ekmee+2cs09gYlzRUdvkJN/t9b8ocYWzb6F 4M1rD+Zwumd6jY4Z0Pm3j2++Dk2myPs= X-Google-Smtp-Source: AK7set/VaM/tRd87+KvjpO4jP7xvodLAwtiDafs6T4TQLSxQiVQL+0JvQJwZHuvJg43BGTQ4mobDppzr77s= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:b71c:0:b0:536:7529:55b4 with SMTP id v28-20020a81b71c000000b00536752955b4mr9597369ywh.3.1678205341764; Tue, 07 Mar 2023 08:09:01 -0800 (PST) Date: Tue, 7 Mar 2023 08:09:00 -0800 In-Reply-To: Mime-Version: 1.0 References: <20230215010717.3612794-1-rananta@google.com> <20230215010717.3612794-11-rananta@google.com> Message-ID: Subject: Re: [REPOST PATCH 10/16] selftests: KVM: aarch64: Add KVM EVTYPE filter PMU test From: Sean Christopherson To: Reiji Watanabe Cc: Raghavendra Rao Ananta , Oliver Upton , Marc Zyngier , Ricardo Koller , James Morse , Suzuki K Poulose , Paolo Bonzini , Jing Zhang , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_080906_216545_8C141C71 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UkVTRU5EIGlzIHRoZSAic3RhbmRhcmQiIHRhZywgbm90IFJFUE9TVC4KCk9uIE1vbiwgTWFyIDA2 LCAyMDIzLCBSZWlqaSBXYXRhbmFiZSB3cm90ZToKPiBIaSBSYWdodSwKPiAKPiBPbiBUdWUsIEZl YiAxNCwgMjAyMyBhdCA1OjA34oCvUE0gUmFnaGF2ZW5kcmEgUmFvIEFuYW50YQo+IDxyYW5hbnRh QGdvb2dsZS5jb20+IHdyb3RlOgo+ID4KPiA+IEtWTSBkb2VzdCd0IGFsbG93IHRoZSBndWVzdHMg dG8gbW9kaWZ5IHRoZSBmaWx0ZXIgdHlwZXMKPiA+IHN1Y2ggY291bnRpbmcgZXZlbnRzIGluIG5v bnNlY3VyZS9zZWN1cmUtRUwyLCBFTDMsIGFuZAo+ID4gc28gb24uIFZhbGlkYXRlIHRoZSBzYW1l IGJ5IGZvcmNlLWNvbmZpZ3VyaW5nIHRoZSBiaXRzCj4gPiBpbiBQTVhFVlRZUEVSX0VMMCwgUE1F VlRZUEVSbl9FTDAsIGFuZCBQTUNDRklMVFJfRUwwCj4gPiByZWdpc3RlcnMuCj4gPgo+ID4gVGhl IHRlc3QgZXh0ZW5kcyBmdXJ0aGVyIGJ5IHRyeWluZyB0byBjcmVhdGUgYW4gZXZlbnQKPiA+IGZv ciBjb3VudGluZyBvbmx5IGluIEVMMiBhbmQgdmFsaWRhdGVzIGlmIHRoZSBjb3VudGVyCj4gPiBp cyBub3QgcHJvZ3Jlc3NpbmcuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogUmFnaGF2ZW5kcmEgUmFv IEFuYW50YSA8cmFuYW50YUBnb29nbGUuY29tPgo+ID4gLS0tCj4gPiArc3RhdGljIHZvaWQgZ3Vl c3RfZXZ0eXBlX2ZpbHRlcl90ZXN0KHZvaWQpCj4gPiArewo+ID4gKyAgICAgICBpbnQgaTsKPiA+ ICsgICAgICAgc3RydWN0IHBtY19hY2Nlc3NvciAqYWNjOwo+ID4gKyAgICAgICB1aW50NjRfdCB0 eXBlciwgY250Owo+ID4gKyAgICAgICBzdHJ1Y3QgYXJtX3NtY2NjX3JlcyByZXM7Cj4gPiArCj4g PiArICAgICAgIHBtdV9lbmFibGUoKTsKPiA+ICsKPiA+ICsgICAgICAgLyoKPiA+ICsgICAgICAg ICogS1ZNIGJsb2NrcyB0aGUgZ3Vlc3RzIGZyb20gY3JlYXRpbmcgZXZlbnRzIGZvciBjb3VudGlu ZyBpbiBTZWN1cmUvTm9uLVNlY3VyZSBIeXAgKEVMMiksCj4gPiArICAgICAgICAqIE1vbml0b3Ig KEVMMyksIGFuZCBNdWx0aXRocmVhZGluZyBjb25maWd1cmF0aW9uLiBJdCBhcHBsaWVzIHRoZSBt YXNrCj4gPiArICAgICAgICAqIEFSTVY4X1BNVV9FVlRZUEVfTUFTSyBhZ2FpbnN0IGd1ZXN0IGFj Y2Vzc2VzIHRvIFBNWEVWVFlQRVJfRUwwLCBQTUVWVFlQRVJuX0VMMCwKPiA+ICsgICAgICAgICog YW5kIFBNQ0NGSUxUUl9FTDAgcmVnaXN0ZXJzIHRvIHByZXZlbnQgdGhpcy4gQ2hlY2sgaWYgS1ZN IGhvbm9ycyB0aGlzIHVzaW5nIGFsbCBwb3NzaWJsZQo+ID4gKyAgICAgICAgKiB3YXlzIHRvIGNv bmZpZ3VyZSB0aGUgRVZUWVBFUi4KPiA+ICsgICAgICAgICovCj4gCj4gSSB3b3VsZCBwcmVmZXIg dG8gYnJlYWsgbG9uZyBsaW5lcyBpbnRvIG11bHRpcGxlIGxpbmVzIGZvciB0aGVzZSBjb21tZW50 cwo+IChvciBvdGhlciBjb21tZW50cyBpbiB0aGVzZSBwYXRjaGVzKSwgYXMgIkxpbnV4IGtlcm5l bCBjb2Rpbmcgc3R5bGUiCj4gc3VnZ2VzdHMuCgorMS4gIEFuZCBvbiB0aGUgb3RoZXIgc2lkZSBv ZiB0aGUgY29pbiwgd3JhcCB0aGUgY2hhbmdlbG9nIGNsb3NlciB0byB+NzUgY2hhcnMsCn41NCBj aGFycyBpcyB3YWFheSB0b28gYWdncmVzc2l2ZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK