From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5F14C678D5 for ; Wed, 8 Mar 2023 12:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A+9+kArDFqMD7qz6roFjTV8cDajCHtDUUSq0on75xa4=; b=bTL8ckLd734lBj3GhyUB7m0tqZ NsZkFdq/3BVykPuh/V8o01opi8IQAlpI6IRNy28TjTN580+OgU9y1oz4I7G9I0tJLdL4Nhmp7i4h5 BOze3hpi2P3J0aNc9cBicdxhWgJcqEe98UMFHn6V249kngvuNYCL0aSdgkGzdYebj3I1Z9UW+PXXS hzLi966PHNiSVhpx8iB2PVitBO8WUq/DOkgZuLA9l72qFuLHHTUv4gId4kbwkl/cxszmOLyzFSDKK dMqZsZxeTEApN7aoZJPEH/4v940kOUFp3oyM71Ihi2nNSvIVR0v/FdkP8Tfb/j++1Mv+5ehU7p3yJ k5DB2OKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZt1C-004s8h-N1; Wed, 08 Mar 2023 12:35:42 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZt0y-004s0o-DX; Wed, 08 Mar 2023 12:35:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=A+9+kArDFqMD7qz6roFjTV8cDajCHtDUUSq0on75xa4=; b=tkvSd7snwbc/j+floPhhA+OFbE lEW0Z0C3FLUY4x7rFhSSgL9uJYCdnhcWvMkmL8sSiIysZB9h/EOjliF2QnOc+TZLjPIMk7D5yhWTO 7HRMICviQC3dHR4WLuajtCr/nQpeNrE2iF/3a9IqUGpYHFlcgZGBkFjCzTWnf1qtUWdPLvN3KV0YT CDEQUw3weHTFvv7dBOfmOgReTLHbefdxrHguYWfoUIEz/6qSgxf5RT4REXXXdNt8V4YRhjj9s09J2 ppOuVhAANR8Z9V2bv0gdUkZfubJHwyQZHUCMIKyFnzwig9SNrFGHEmidmEc7pW3Kghdw/FTwFiLM/ vZQ+H2cQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45066) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pZt0m-0002Tl-36; Wed, 08 Mar 2023 12:35:16 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pZt0e-0002Zg-Jl; Wed, 08 Mar 2023 12:35:08 +0000 Date: Wed, 8 Mar 2023 12:35:08 +0000 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Daniel Golle , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Vladimir Oltean , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork , Alexander Couzens Subject: Re: [PATCH net-next v12 09/18] net: ethernet: mtk_eth_soc: Fix link status for none-SGMII modes Message-ID: References: <1590fb0e69f6243ac6a961b16bf7ae7534f46949.1678201958.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_043528_801151_FD77AA81 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Mar 08, 2023 at 12:44:57PM +0100, Frank Wunderlich wrote: > Am 8. März 2023 12:38:31 MEZ schrieb "Russell King (Oracle)" : > >On Tue, Mar 07, 2023 at 03:54:11PM +0000, Daniel Golle wrote: > >> Link partner advertised link modes are not reported by the SerDes > >> hardware if not operating in SGMII mode. Hence we cannot use > >> phylink_mii_c22_pcs_decode_state() in this case. > >> Implement reporting link and an_complete only and use speed according to > >> the interface mode. > >> > >> Fixes: 14a44ab0330d ("net: mtk_eth_soc: partially convert to phylink_pcs") > >> Signed-off-by: Daniel Golle > > > >This has been proven to work by Frank Wunderlich last October, so by > >making this change, you will be regressing his setup. > > Hi > > My tests were done with 1 kind of 1g fibre sfp as i only have these atm...have ordered some 2g5 rj54 ones,but don't have them yet. I'm not sure if they are working with/without sgmii (1000base-X) and if they have builtin phy. Fiber SFPs do not have a built in PHY. They merely convert the serdes electrical waveform into light and back again, possibly with some retiming of the received waveform, and a bit of monitoring. They're pretty simple devices. They certainly do not change the protocol in any way. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23308C64EC4 for ; Wed, 8 Mar 2023 12:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IvGaMxeczRZ6ePBMJAAePwWuuGEXucn88l1lycGd3LM=; b=aOXxJjO1vno24z 8qirFBetRJlbez/G2n5KqBW45NpKhFNT6EtiPMemXTiU+8ITCywBo3ZTYoD5A6VAO3FHRHxjzZIQm 90kPJxVB/3TaKVZgMXVLVkb/rx2kNNSaKiLWI86uzQGVOS8tD/AQ8cblvS4rpMZToeJ0Agw8Ac+Gr nZhdKA9c3OeDPddFSUiqjlt/rqLpdRdDgrb5jQibrPedz4YsLGn0Jf7Osh+E2gOkmcGNi5zxV0GCg Ibgzaq3P1FQwXxTzUc4L3Zjlzay3uSNpfjqSabjlfRX43XwlJXyYTtLBig+173b93TSeV1XkJZ5vs eQIz168UHPZmSBaWlW4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZt1D-004s99-UQ; Wed, 08 Mar 2023 12:35:44 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZt0y-004s0o-DX; Wed, 08 Mar 2023 12:35:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=A+9+kArDFqMD7qz6roFjTV8cDajCHtDUUSq0on75xa4=; b=tkvSd7snwbc/j+floPhhA+OFbE lEW0Z0C3FLUY4x7rFhSSgL9uJYCdnhcWvMkmL8sSiIysZB9h/EOjliF2QnOc+TZLjPIMk7D5yhWTO 7HRMICviQC3dHR4WLuajtCr/nQpeNrE2iF/3a9IqUGpYHFlcgZGBkFjCzTWnf1qtUWdPLvN3KV0YT CDEQUw3weHTFvv7dBOfmOgReTLHbefdxrHguYWfoUIEz/6qSgxf5RT4REXXXdNt8V4YRhjj9s09J2 ppOuVhAANR8Z9V2bv0gdUkZfubJHwyQZHUCMIKyFnzwig9SNrFGHEmidmEc7pW3Kghdw/FTwFiLM/ vZQ+H2cQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45066) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pZt0m-0002Tl-36; Wed, 08 Mar 2023 12:35:16 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pZt0e-0002Zg-Jl; Wed, 08 Mar 2023 12:35:08 +0000 Date: Wed, 8 Mar 2023 12:35:08 +0000 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Daniel Golle , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Vladimir Oltean , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork , Alexander Couzens Subject: Re: [PATCH net-next v12 09/18] net: ethernet: mtk_eth_soc: Fix link status for none-SGMII modes Message-ID: References: <1590fb0e69f6243ac6a961b16bf7ae7534f46949.1678201958.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_043528_801151_FD77AA81 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 08, 2023 at 12:44:57PM +0100, Frank Wunderlich wrote: > Am 8. M=E4rz 2023 12:38:31 MEZ schrieb "Russell King (Oracle)" : > >On Tue, Mar 07, 2023 at 03:54:11PM +0000, Daniel Golle wrote: > >> Link partner advertised link modes are not reported by the SerDes > >> hardware if not operating in SGMII mode. Hence we cannot use > >> phylink_mii_c22_pcs_decode_state() in this case. > >> Implement reporting link and an_complete only and use speed according = to > >> the interface mode. > >> = > >> Fixes: 14a44ab0330d ("net: mtk_eth_soc: partially convert to phylink_p= cs") > >> Signed-off-by: Daniel Golle > > > >This has been proven to work by Frank Wunderlich last October, so by > >making this change, you will be regressing his setup. > = > Hi > = > My tests were done with 1 kind of 1g fibre sfp as i only have these atm..= .have ordered some 2g5 rj54 ones,but don't have them yet. I'm not sure if t= hey are working with/without sgmii (1000base-X) and if they have builtin ph= y. Fiber SFPs do not have a built in PHY. They merely convert the serdes electrical waveform into light and back again, possibly with some retiming of the received waveform, and a bit of monitoring. They're pretty simple devices. They certainly do not change the protocol in any way. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel