From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: michael.roth@amd.com, kkostiuk@redhat.com,
marcandre.lureau@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v5 3/3] qga: test: Add tests for `merged` flag
Date: Fri, 10 Mar 2023 09:36:13 +0000 [thread overview]
Message-ID: <ZAr6DfC0Fa51neXy@redhat.com> (raw)
In-Reply-To: <20a27290153aa05c4076d71c665f1090112765aa.1678401400.git.dxu@dxuuu.xyz>
On Thu, Mar 09, 2023 at 03:40:58PM -0700, Daniel Xu wrote:
> This commit adds a test to ensure `merged` functions as expected.
> We also add a negative test to ensure we haven't regressed previous
> functionality.
>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
> tests/unit/test-qga.c | 158 +++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 141 insertions(+), 17 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-03-10 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 22:40 [PATCH v5 0/3] qga: Support merging output streams in guest-exec Daniel Xu
2023-03-09 22:40 ` [PATCH v5 1/3] qga: Refactor guest-exec capture-output to take enum Daniel Xu
2023-03-10 9:20 ` Daniel P. Berrangé
2023-03-09 22:40 ` [PATCH v5 2/3] qga: Add `merged` variant to GuestExecCaptureOutputMode Daniel Xu
2023-03-10 9:21 ` Daniel P. Berrangé
2023-03-10 9:24 ` Daniel P. Berrangé
2023-03-23 0:15 ` Daniel Xu
2023-03-09 22:40 ` [PATCH v5 3/3] qga: test: Add tests for `merged` flag Daniel Xu
2023-03-10 9:36 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAr6DfC0Fa51neXy@redhat.com \
--to=berrange@redhat.com \
--cc=dxu@dxuuu.xyz \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.