From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: bingbu.cao@intel.com
Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
djrscally@gmail.com, bingbu.cao@linux.intel.com
Subject: Re: [PATCH v2] media: ipu3-cio2: support multiple sensors and VCMs with HID name
Date: Fri, 10 Mar 2023 16:49:45 +0200 [thread overview]
Message-ID: <ZAtDiUXvzKzsoKDX@smile.fi.intel.com> (raw)
In-Reply-To: <20230307063110.1459508-1-bingbu.cao@intel.com>
On Tue, Mar 07, 2023 at 02:31:10PM +0800, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
>
> In current cio2-bridge, it is using the hid name to register software
> node and software node will create kobject and sysfs entry according to
> the node name, if there are multiple sensors and VCMs which are sharing
> same HID name, it will cause the software nodes registration failure:
>
> sysfs: cannot create duplicate filename '/kernel/software_nodes/dw9714'
> ...
> Call Trace:
> sysfs_create_dir_ns+0xbc/0xd0
> kobject_add_internal
> kobject_init_and_add
> swnode_register
> software_node_register
The above lines are not so valuable. You can remove them.
> software_node_register_nodes
> cio2_bridge_init
> ...
> kobject_add_internal failed for dw9714 with -EEXIST,
> don't try to register things with the same name in the same directory.
>
> One solution is appending the sensor link(Mipi Port) in SSDB as suffix
> of the node name to fix this problem.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-03-10 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 6:31 [PATCH v2] media: ipu3-cio2: support multiple sensors and VCMs with HID name bingbu.cao
2023-03-10 14:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAtDiUXvzKzsoKDX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.