From: Eric Biggers <ebiggers@kernel.org>
To: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Mike Cloaked <mike.cloaked@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Yu Kuai <yukuai3@huawei.com>, Genes Lists <lists@sapience.com>
Subject: Re: Possible kernel fs block code regression in 6.2.3 umounting usb drives
Date: Fri, 10 Mar 2023 14:53:19 -0800 [thread overview]
Message-ID: <ZAu030xtaPBGFPBS@sol.localdomain> (raw)
In-Reply-To: <88b36c03-780f-61a5-4a66-e69072aa7536@sapience.com>
On Fri, Mar 10, 2023 at 04:08:21PM -0500, Genes Lists wrote:
> On 3/10/23 15:23, Jens Axboe wrote:
> > On 3/10/23 1:16 PM, Eric Biggers wrote:
> ...
> > But I would revert:
> >
> > bfe46d2efe46c5c952f982e2ca94fe2ec5e58e2a
> > 57a425badc05c2e87e9f25713e5c3c0298e4202c
> >
> > in that order from 6.2.3 and see if that helps. Adding Yu.
> >
> Confirm the 2 Reverts fixed in my tests as well (nvme + sata drives).
> Nasty crash - some needed to be power cycled as they hung on shutdown.
>
> Thank you!
>
> gene
>
>
Great, thanks. BTW, 6.1 is also affected. A simple reproducer is to run:
dmsetup create dev --table "0 128 zero"
dmsetup remove dev
The following kconfigs are needed for the bug to be hit:
CONFIG_BLK_CGROUP=y
CONFIG_BLK_DEV_THROTTLING=y
CONFIG_BLK_DEV_THROTTLING_LOW=y
Sasha or Greg, can you please revert the indicated commits from 6.1 and 6.2?
- Eric
next prev parent reply other threads:[~2023-03-10 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOCAAm7AEY9tkZpu2j+Of91fCE4UuE_PqR0UqNv2p2mZM9kqKw@mail.gmail.com>
2023-03-10 19:33 ` Possible kernel fs block code regression in 6.2.3 umounting usb drives Mike Cloaked
2023-03-10 20:14 ` Eric Biggers
2023-03-10 20:16 ` Eric Biggers
2023-03-10 20:23 ` Jens Axboe
2023-03-10 21:08 ` Genes Lists
2023-03-10 22:53 ` Eric Biggers [this message]
2023-03-11 9:32 ` Greg Kroah-Hartman
2023-03-11 16:40 ` Jens Axboe
2023-03-11 2:07 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAu030xtaPBGFPBS@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@sapience.com \
--cc=mike.cloaked@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.