From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Subject: Re: [PATCH 3/4] kobject: validate ktype release function during add
Date: Sat, 11 Mar 2023 09:10:50 +0100 [thread overview]
Message-ID: <ZAw3iu+EquTj4y5U@kroah.com> (raw)
In-Reply-To: <20230311-kobject-warning-v1-3-1ebba4f71fb5@weissschuh.net>
On Sat, Mar 11, 2023 at 03:14:48AM +0000, Thomas Weißschuh wrote:
> Validating the ktype during cleanup is suboptimal.
> Many kobjects are only destroyed during shutdown which makes it hard to
> observe the messages.
>
> Instead perform the validation when the object is added.
As much as I would like to do this, it will cause way too many
false-positives at this point in time, sorry.
Yes, kobjects should always have a release function, but for some, they
are static structures and so do not have them, which is why we only
report the problem when the object is going away as that is when it
matters.
So if you fix up all the in-kernel static kobjects first, then we can
take this type of change, sorry.
Your first 2 are great though, I'll go queue them up next week, thanks
for the cleanups there.
greg k-h
next prev parent reply other threads:[~2023-03-11 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 3:14 [PATCH 0/4] kobject: properly warn on missing release function Thomas Weißschuh
2023-03-11 3:14 ` [PATCH 1/4] kobject: define common logging prefix Thomas Weißschuh
2023-03-11 3:14 ` [PATCH 2/4] kobject: align stacktrace levels to logging message Thomas Weißschuh
2023-03-11 3:14 ` [PATCH 3/4] kobject: validate ktype release function during add Thomas Weißschuh
2023-03-11 8:10 ` Greg Kroah-Hartman [this message]
2023-03-11 3:14 ` [PATCH 4/4] kobject: upgrade log of missing release func to warn Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAw3iu+EquTj4y5U@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.