From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Patrice Duroux <patrice.duroux@gmail.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] replace 2&>1 by 2>&1
Date: Fri, 24 Mar 2023 17:09:24 -0300 [thread overview]
Message-ID: <ZB4DdJ14nz84CTCl@kernel.org> (raw)
In-Reply-To: <CAP-5=fUy_mLJ2-z89dc0vro+1aqWFn-CrvqZA1Ji3etPXg+RTg@mail.gmail.com>
Em Thu, Mar 23, 2023 at 11:03:49AM -0700, Ian Rogers escreveu:
> On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> > >
> > > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
> >
> > Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> > Acked-by: Ian Rogers <irogers@google.com>
> >
> > Thanks,
> > Ian
>
> Arnaldo, could we pick this up?
Yeah, but next time please write in the subject line that its a patch
for the perf tools :-)
- Arnaldo
> Thanks,
> Ian
>
> > > ---
> > > tools/perf/tests/shell/record_offcpu.sh | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > > index e01973d4e0fb..f062ae9a95e1 100755
> > > --- a/tools/perf/tests/shell/record_offcpu.sh
> > > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > > @@ -65,7 +65,7 @@ test_offcpu_child() {
> > >
> > > # perf bench sched messaging creates 400 processes
> > > if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > > - perf bench sched messaging -g 10 > /dev/null 2&>1
> > > + perf bench sched messaging -g 10 > /dev/null 2>&1
> > > then
> > > echo "Child task off-cpu test [Failed record]"
> > > err=1
> > > --
> > > 2.39.2
> > >
--
- Arnaldo
next prev parent reply other threads:[~2023-03-24 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 13:58 a tiny patch related to two shell scripts that use 2&>1 in place of 2>&1 Patrice Duroux
2023-03-03 19:20 ` [PATCH 2/2] replace 2&>1 by 2>&1 Patrice Duroux
2023-03-03 20:28 ` Shuah Khan
2023-03-03 19:30 ` [PATCH 1/2] " Patrice Duroux
2023-03-06 21:46 ` Ian Rogers
2023-03-23 18:03 ` Ian Rogers
2023-03-24 20:09 ` Arnaldo Carvalho de Melo [this message]
2023-03-25 3:18 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB4DdJ14nz84CTCl@kernel.org \
--to=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=patrice.duroux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.