From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B6BC6FD1C for ; Sat, 25 Mar 2023 08:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231984AbjCYIZD (ORCPT ); Sat, 25 Mar 2023 04:25:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232139AbjCYIZA (ORCPT ); Sat, 25 Mar 2023 04:25:00 -0400 Received: from zeeaster.vergenet.net (zeeaster.vergenet.net [206.189.110.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2C23CC19; Sat, 25 Mar 2023 01:24:54 -0700 (PDT) Received: from madeliefje.horms.nl (86-88-72-229.fixed.kpn.net [86.88.72.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by zeeaster.vergenet.net (Postfix) with ESMTPSA id D2DBA202AA; Sat, 25 Mar 2023 08:24:22 +0000 (UTC) Received: by madeliefje.horms.nl (Postfix, from userid 7100) id 38A883F81; Sat, 25 Mar 2023 09:24:22 +0100 (CET) Date: Sat, 25 Mar 2023 09:24:22 +0100 From: Simon Horman To: Sean Anderson Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Simon Horman , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 09/10] net: sunhme: Inline error returns Message-ID: References: <20230324175136.321588-1-seanga2@gmail.com> <20230324175136.321588-10-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230324175136.321588-10-seanga2@gmail.com> Organisation: Horms Solutions BV X-Virus-Scanned: clamav-milter 0.103.8 at zeeaster X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 01:51:35PM -0400, Sean Anderson wrote: > The err_out label used to have cleanup. Now that it just returns, inline it > everywhere. > > Signed-off-by: Sean Anderson Reviewed-by: Simon Horman