From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: viro@zeniv.linux.org.uk, jaegeuk@kernel.org, ebiggers@kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com
Subject: Re: [PATCH 1/7] fs: Expose name under lookup to d_revalidate hook
Date: Sat, 25 Mar 2023 09:33:10 -0400 [thread overview]
Message-ID: <ZB74FsfDDUegrqqx@mit.edu> (raw)
In-Reply-To: <20230323143320.GC136146@mit.edu>
On Thu, Mar 23, 2023 at 10:33:20AM -0400, Theodore Ts'o wrote:
> On Wed, Jun 22, 2022 at 03:45:57PM -0400, Gabriel Krisman Bertazi wrote:
> > Negative dentries support on case-insensitive ext4/f2fs will require
> > access to the name under lookup to ensure it matches the dentry. This
> > adds an optional new flavor of cached dentry revalidation hook to expose
> > this extra parameter.
> >
> > I'm fine with extending d_revalidate instead of adding a new hook, if
> > it is considered cleaner and the approach is accepted. I wrote a new
> > hook to simplify reviewing.
> >
> > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Reviewed-by: Theodore Ts'o <tytso@mit.edu>
>
> Al, could you take a look and see if you have any objections?
Ping, Al, any objsections if I take Gabriel's patch series via the
ext4 tree?
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: kernel@collabora.com, linux-f2fs-devel@lists.sourceforge.net,
ebiggers@kernel.org, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/7] fs: Expose name under lookup to d_revalidate hook
Date: Sat, 25 Mar 2023 09:33:10 -0400 [thread overview]
Message-ID: <ZB74FsfDDUegrqqx@mit.edu> (raw)
In-Reply-To: <20230323143320.GC136146@mit.edu>
On Thu, Mar 23, 2023 at 10:33:20AM -0400, Theodore Ts'o wrote:
> On Wed, Jun 22, 2022 at 03:45:57PM -0400, Gabriel Krisman Bertazi wrote:
> > Negative dentries support on case-insensitive ext4/f2fs will require
> > access to the name under lookup to ensure it matches the dentry. This
> > adds an optional new flavor of cached dentry revalidation hook to expose
> > this extra parameter.
> >
> > I'm fine with extending d_revalidate instead of adding a new hook, if
> > it is considered cleaner and the approach is accepted. I wrote a new
> > hook to simplify reviewing.
> >
> > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Reviewed-by: Theodore Ts'o <tytso@mit.edu>
>
> Al, could you take a look and see if you have any objections?
Ping, Al, any objsections if I take Gabriel's patch series via the
ext4 tree?
- Ted
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-03-25 13:33 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 19:45 [PATCH 0/7] Support negative dentries on case-insensitive directories Gabriel Krisman Bertazi
2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-06-22 19:45 ` [PATCH 1/7] fs: Expose name under lookup to d_revalidate hook Gabriel Krisman Bertazi
2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-03-23 14:33 ` Theodore Ts'o
2023-03-23 14:33 ` [f2fs-dev] " Theodore Ts'o
2023-03-25 13:33 ` Theodore Ts'o [this message]
2023-03-25 13:33 ` Theodore Ts'o
2023-03-26 5:03 ` Al Viro
2023-03-26 5:03 ` [f2fs-dev] " Al Viro
2022-06-22 19:45 ` [PATCH 2/7] fs: Add DCACHE_CASEFOLD_LOOKUP flag Gabriel Krisman Bertazi
2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-03-23 14:33 ` Theodore Ts'o
2023-03-23 14:33 ` [f2fs-dev] " Theodore Ts'o
2022-06-22 19:45 ` [PATCH 3/7] libfs: Validate negative dentries in case-insensitive directories Gabriel Krisman Bertazi
2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-03-23 14:36 ` Theodore Ts'o
2023-03-23 14:36 ` [f2fs-dev] " Theodore Ts'o
2023-03-26 4:46 ` Al Viro
2023-03-26 4:46 ` [f2fs-dev] " Al Viro
2023-03-31 15:31 ` Gabriel Krisman Bertazi
2023-03-31 15:31 ` Gabriel Krisman Bertazi
2022-06-22 19:46 ` [PATCH 4/7] libfs: Support revalidation of encrypted case-insensitive dentries Gabriel Krisman Bertazi
2022-06-22 19:46 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-03-23 14:37 ` Theodore Ts'o
2023-03-23 14:37 ` [f2fs-dev] " Theodore Ts'o
2022-06-22 19:46 ` [PATCH 5/7] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi
2022-06-22 19:46 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-03-23 14:39 ` Theodore Ts'o
2023-03-23 14:39 ` [f2fs-dev] " Theodore Ts'o
2022-06-22 19:46 ` [PATCH 6/7] ext4: Enable negative dentries on case-insensitive lookup Gabriel Krisman Bertazi
2022-06-22 19:46 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-06-23 7:29 ` kernel test robot
2022-06-23 7:29 ` [f2fs-dev] " kernel test robot
2022-06-23 16:36 ` Gabriel Krisman Bertazi
2022-06-23 16:36 ` Gabriel Krisman Bertazi
2022-06-23 16:36 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-03-23 14:39 ` Theodore Ts'o
2023-03-23 14:39 ` [f2fs-dev] " Theodore Ts'o
2022-06-22 19:46 ` [PATCH 7/7] f2fs: " Gabriel Krisman Bertazi
2022-06-22 19:46 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-06-23 12:44 ` kernel test robot
2022-06-23 12:44 ` [f2fs-dev] " kernel test robot
2023-02-24 22:36 ` [PATCH 0/7] Support negative dentries on case-insensitive directories Daniel Rosenberg
2023-02-24 22:36 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB74FsfDDUegrqqx@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.