All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Roman Lozko <lozko.roma@gmail.com>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf scripts: intel-pt-events.py: Fix IPC output for Python 2
Date: Tue, 14 Mar 2023 08:44:43 -0300	[thread overview]
Message-ID: <ZBBeKyM++DM7lvmI@kernel.org> (raw)
In-Reply-To: <19a697ba-9520-92a0-1419-07c5a66481b1@intel.com>

Em Fri, Mar 10, 2023 at 06:50:48PM +0200, Adrian Hunter escreveu:
> On 10/03/23 17:04, Roman Lozko wrote:
> > Integers are not converted to floats during division in Python 2
> > which results in incorrect IPC values. Fix by switching to new division
> > behavior.
> 
> There is usually a blank line here

Fixed
 
> > Fixes: a483e64c0b62 ("perf scripting python: intel-pt-events.py: Add --insn-trace and --src-trace")
> > Signed-off-by: Roman Lozko <lozko.roma@gmail.com>
> 
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks, applied.

- Arnaldo

 
> > ---
> >  tools/perf/scripts/python/intel-pt-events.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scripts/python/intel-pt-events.py
> > index 08862a2582f4..1c76368f13c1 100644
> > --- a/tools/perf/scripts/python/intel-pt-events.py
> > +++ b/tools/perf/scripts/python/intel-pt-events.py
> > @@ -11,7 +11,7 @@
> >  # FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> >  # more details.
> >  
> > -from __future__ import print_function
> > +from __future__ import division, print_function
> >  
> >  import io
> >  import os
> 

-- 

- Arnaldo

      reply	other threads:[~2023-03-14 11:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 11:10 [PATCH] fix IPC output in perf intel-pt-events script Roman Lozko
2023-03-10 13:32 ` Adrian Hunter
2023-03-10 14:02   ` Roman Lozko
2023-03-10 14:19     ` Adrian Hunter
2023-03-10 15:04   ` [PATCH v2] perf scripts: intel-pt-events.py: Fix IPC output for Python 2 Roman Lozko
2023-03-10 16:50     ` Adrian Hunter
2023-03-14 11:44       ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBBeKyM++DM7lvmI@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=lozko.roma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.