From: Simon Horman <simon.horman@corigine.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Gavin Li <gavinl@nvidia.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
roopa@nvidia.com, eng.alaamohamedsoliman.am@gmail.com,
bigeasy@linutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gavi@nvidia.com, roid@nvidia.com,
maord@nvidia.com, saeedm@nvidia.com
Subject: Re: [PATCH net-next v7 4/5] ip_tunnel: Preserve pointer const in ip_tunnel_info_opts
Date: Tue, 14 Mar 2023 16:42:43 +0100 [thread overview]
Message-ID: <ZBCV8/IFqiNr8Hr1@corigine.com> (raw)
In-Reply-To: <CANn89iLDUR_3pmxco47VQkvWweq2g4Og6UhtLN1gQMQiCUy2KQ@mail.gmail.com>
On Mon, Mar 13, 2023 at 07:57:23PM -0700, Eric Dumazet wrote:
> On Mon, Mar 13, 2023 at 12:51 AM Gavin Li <gavinl@nvidia.com> wrote:
> >
> > Change ip_tunnel_info_opts( ) from static function to macro to cast return
> > value and preserve the const-ness of the pointer.
> >
> > Signed-off-by: Gavin Li <gavinl@nvidia.com>
> > ---
> > include/net/ip_tunnels.h | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks Gavin,
this addresses my concerns.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-14 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 7:51 [PATCH net-next v7 0/5] net/mlx5e: Add GBP VxLAN HW offload support Gavin Li
2023-03-13 7:51 ` [PATCH net-next v7 1/5] vxlan: Remove unused argument from vxlan_build_gbp_hdr( ) and vxlan_build_gpe_hdr( ) Gavin Li
2023-03-13 7:51 ` [PATCH net-next v7 2/5] vxlan: Expose helper vxlan_build_gbp_hdr Gavin Li
2023-03-13 7:51 ` [PATCH net-next v7 3/5] net/mlx5e: Add helper for encap_info_equal for tunnels with options Gavin Li
2023-03-13 7:51 ` [PATCH net-next v7 4/5] ip_tunnel: Preserve pointer const in ip_tunnel_info_opts Gavin Li
2023-03-14 2:57 ` Eric Dumazet
2023-03-14 15:42 ` Simon Horman [this message]
2023-03-13 7:51 ` [PATCH net-next v7 5/5] net/mlx5e: TC, Add support for VxLAN GBP encap/decap flows offload Gavin Li
2023-03-15 7:32 ` Jakub Kicinski
2023-03-16 6:57 ` Gavin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBCV8/IFqiNr8Hr1@corigine.com \
--to=simon.horman@corigine.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=gavi@nvidia.com \
--cc=gavinl@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maord@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roid@nvidia.com \
--cc=roopa@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.