Re: Help in patch message

[Alison Schofield <alison.schofield@intel.com>]

On Tue, Mar 14, 2023 at 09:53:46AM +0800, Kloudifold wrote:
> Dear Outreachy Mentors,
> 
> I hope this email finds you well. As an Outreachy applicant,
> I have been working on submitting patches to the kernel, but
> I seem to be having trouble getting them accepted. I have
> read the Outreachy tutorials and tried to follow the best practices,
> but my patch messages keep getting rejected.
> 
> I really wonder if I have some kind of language problem, I don't
> actually know how to say something?
> 
> Recently, I submitted a patch that has been rejected, and I am not
> sure whether to go ahead and fix it or create a new one.
> I would greatly appreciate your guidance on how to proceed
> 
> Thank you for your help and guidance throughout this process.
> I look forward to your response.

Hi Kloudifold,

I echo the other responses here. 
Before you press 'send' on v3, walk thru the tutorial again. There will
be parts that make more sense now that you are doing revisions and 
that you have comments.

It looks like you will be preparing and sending v3 of your camelcase patch.

The biggest thing I see recently is compile errors on your patch, and
others patches. Sometimes lkp finds compile errors in build environments
that are less common, and that is less of a concern. They need to be fixed,
but I don't expect you all to run all build environments. That is what lkp does.

That said, be sure to check for new .o's each time you think you are 
compiling the driver.

Kudos to you for driving one patch to completion before sending out
another!

Keep at it!
Alison

> 
> Best regards,
> 
> Kloudifold
> 
>