From: Simon Horman <simon.horman@corigine.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] can: rcar_canfd: Improve error messages
Date: Tue, 14 Mar 2023 17:48:43 +0100 [thread overview]
Message-ID: <ZBClaxLZdFJSCaI+@corigine.com> (raw)
In-Reply-To: <70d430248415a3304573df4faec19f6a3135db28.1678811267.git.geert+renesas@glider.be>
On Tue, Mar 14, 2023 at 05:29:25PM +0100, Geert Uytterhoeven wrote:
> Improve printed error messages:
> - Replace numerical error codes by mnemotechnic error codes, to
> improve the user experience in case of errors,
> - Drop parentheses around printed numbers, cfr.
> Documentation/process/coding-style.rst,
> - Drop printing of an error message in case of out-of-memory, as the
> core memory allocation code already takes care of this.
>
> Suggested-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
prev parent reply other threads:[~2023-03-14 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 16:29 [PATCH v3] can: rcar_canfd: Improve error messages Geert Uytterhoeven
2023-03-14 16:48 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBClaxLZdFJSCaI+@corigine.com \
--to=simon.horman@corigine.com \
--cc=geert+renesas@glider.be \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.