From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Davide Caratti <dcaratti@redhat.com>,
Pedro Tammela <pctammela@mojatatu.com>,
Marcelo Leitner <mleitner@redhat.com>,
Phil Sutter <psutter@redhat.com>
Subject: Re: [PATCH net 2/2] net/sched: act_api: add specific EXT_WARN_MSG for tc action
Date: Wed, 15 Mar 2023 17:39:59 +0800 [thread overview]
Message-ID: <ZBGSbzgL2fVvBYG5@Laptop-X1> (raw)
In-Reply-To: <20230315004532.60fb0a41@kernel.org>
On Wed, Mar 15, 2023 at 12:45:32AM -0700, Jakub Kicinski wrote:
> On Tue, 14 Mar 2023 14:58:02 +0800 Hangbin Liu wrote:
> > --- a/include/uapi/linux/rtnetlink.h
> > +++ b/include/uapi/linux/rtnetlink.h
> > @@ -789,6 +789,7 @@ enum {
> > TCA_ROOT_FLAGS,
> > TCA_ROOT_COUNT,
> > TCA_ROOT_TIME_DELTA, /* in msecs */
> > + TCA_ACT_EXT_WARN_MSG,
>
> Not TCA_ROOT_EXT_... ?
> All other attrs in this set are called TCA_ROOT_x
Hmm, when we discussed this issue, Jamal suggested to use TCAA_EXT_WARN_MSG.
I expand it to TCA_ACT_EXT_WARN_MSG to correspond with the format of TCA_*.
But your suggest TCA_ROOT_EXT_ also makes sense. I'm OK to change it.
Jamal, what do you think?
Thanks
Hangbin
next prev parent reply other threads:[~2023-03-15 9:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 6:58 [PATCH net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action Hangbin Liu
2023-03-14 6:58 ` [PATCH net 1/2] Revert "net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy" Hangbin Liu
2023-03-14 22:32 ` Jamal Hadi Salim
2023-03-14 6:58 ` [PATCH net 2/2] net/sched: act_api: add specific EXT_WARN_MSG for tc action Hangbin Liu
2023-03-14 22:35 ` Jamal Hadi Salim
2023-03-15 9:47 ` Hangbin Liu
2023-03-15 18:49 ` Jamal Hadi Salim
2023-03-16 3:33 ` Hangbin Liu
2023-03-16 9:39 ` Jamal Hadi Salim
2023-03-15 7:45 ` Jakub Kicinski
2023-03-15 9:39 ` Hangbin Liu [this message]
2023-03-15 18:47 ` Jamal Hadi Salim
2023-03-14 7:04 ` [PATCH iproute2 1/2] Revert "tc: m_action: fix parsing of TCA_EXT_WARN_MSG" Hangbin Liu
2023-03-14 12:10 ` Andrea Claudi
2023-03-15 7:46 ` Jakub Kicinski
2023-03-15 9:31 ` Hangbin Liu
2023-03-14 7:08 ` [PATCH iproute2 2/2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG by using different enum Hangbin Liu
2023-03-14 9:22 ` Davide Caratti
2023-03-14 9:20 ` [PATCH net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action Davide Caratti
2023-03-14 10:15 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBGSbzgL2fVvBYG5@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=psutter@redhat.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.