From: Matthew Brost <matthew.brost@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 2/6] drm/xe/migrate: Update cpu page-table updates
Date: Wed, 15 Mar 2023 15:23:28 +0000 [thread overview]
Message-ID: <ZBHi8LilKnutuzQG@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <f1dd8fdf-09cc-01bd-f4db-f2991ae77883@linux.intel.com>
On Wed, Mar 15, 2023 at 04:19:20PM +0100, Thomas Hellström wrote:
>
> On 3/14/23 13:15, Matthew Auld wrote:
> > On Mon, 13 Mar 2023 at 20:46, Thomas Hellström
> > <thomas.hellstrom@linux.intel.com> wrote:
> > > Don't wait for GPU to be able to update page-tables using CPU. Putting
> > > ourselves to sleep may be more of a problem than using GPU for
> > > page-table updates. Also allow the vm to be NULL since the migrate
> > > kunit test uses NULL for vm.
> > >
> > > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Seems reasonable to me, but I'm not really familiar with the history here,
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Hmm, it turns out that this change uncovers a bug in xe_exec_basic igt
> (unless I misunderstand the syncobj semantics). I've posted a fix for that
> on igt-dev. With a little luck that also fixes the strange igt failures
> we've been seeing with deferred storage allocation on PVC.
>
This change LGTM too and yea I've been aware of the issue with xe_exec_basic for
a while, after a quick look your fix does look correct. Will do a full review of
the xe_exec_basic fix today.
Matt
> I won't merge this until the igt fix goes in.
>
> /Thomas
>
>
next prev parent reply other threads:[~2023-03-15 15:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 20:45 [Intel-xe] [PATCH 0/6] Cpu page-table updates and fixes Thomas Hellström
2023-03-13 20:45 ` [Intel-xe] [PATCH 1/6] drm/xe: Use a define to set initial seqno for fences Thomas Hellström
2023-03-14 11:54 ` Matthew Auld
2023-03-14 13:03 ` Thomas Hellström
2023-03-14 16:02 ` Matthew Auld
2023-03-15 15:26 ` Matthew Brost
2023-03-15 15:32 ` Thomas Hellström
2023-03-13 20:45 ` [Intel-xe] [PATCH 2/6] drm/xe/migrate: Update cpu page-table updates Thomas Hellström
2023-03-14 12:15 ` Matthew Auld
2023-03-14 13:11 ` Thomas Hellström
2023-03-15 15:19 ` Thomas Hellström
2023-03-15 15:23 ` Matthew Brost [this message]
2023-03-13 20:45 ` [Intel-xe] [PATCH 3/6] drm/xe/tests: Support CPU page-table updates in the migrate test Thomas Hellström
2023-03-14 12:25 ` Matthew Auld
2023-03-13 20:45 ` [Intel-xe] [PATCH 4/6] drm/xe: Introduce xe_engine_is_idle() Thomas Hellström
2023-03-14 15:32 ` Matthew Auld
2023-03-13 20:45 ` [Intel-xe] [PATCH 5/6] drm/xe: Use a small negative initial seqno Thomas Hellström
2023-03-14 15:46 ` Matthew Auld
2023-03-15 15:44 ` Matthew Brost
2023-03-13 20:45 ` [Intel-xe] [PATCH 6/6] drm/xe/tests: Test both CPU- and GPU page-table updates with the migrate test Thomas Hellström
2023-03-14 15:53 ` Matthew Auld
2023-03-13 21:03 ` [Intel-xe] ✓ CI.Patch_applied: success for Cpu page-table updates and fixes Patchwork
2023-03-13 21:05 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-13 21:08 ` [Intel-xe] ✓ CI.Build: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBHi8LilKnutuzQG@DUT025-TGLU.fm.intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.