From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Piotr Raczynski <piotr.raczynski@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Parav Pandit <parav@nvidia.com>,
Daniel Jurgens <danielj@nvidia.com>
Subject: Re: [net 03/14] net/mlx5: Fix setting ec_function bit in MANAGE_PAGES
Date: Wed, 15 Mar 2023 15:53:39 -0700 [thread overview]
Message-ID: <ZBJMcw2i+6ijmmmA@x130> (raw)
In-Reply-To: <20230315143334.434bbbda@kernel.org>
On 15 Mar 14:33, Jakub Kicinski wrote:
>On Wed, 15 Mar 2023 14:09:03 -0700 Saeed Mahameed wrote:
>> When looking from a larger scope of multiple drivers and stack, yes it
>> makes total sense.
>>
>> Ack, will enforce adding mlx5 prefix to static functions as well..
>>
>> Let me know if you want me to fix this series for the time being,
>> I see another comment from leon on a blank line in one of the commit
>> messages.
>>
>> I can handle both and post v2 at the same time.
>
>It's a long standing problem, we can keep it as is, if you don't have
>any other code changes to the series. Just change the recommended style
>going forward.
I see that patchwork is complaining about the blank lines, I will fix
both the mlx5 prefix and the blank lines, Will post V2.
Thanks.
next prev parent reply other threads:[~2023-03-15 22:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 17:49 [pull request][net 00/14] mlx5 fixes 2023-03-14 Saeed Mahameed
2023-03-14 17:49 ` [net 01/14] net/mlx5e: Fix macsec ASO context alignment Saeed Mahameed
2023-03-14 17:49 ` [net 02/14] net/mlx5e: Don't cache tunnel offloads capability Saeed Mahameed
2023-03-15 13:14 ` Piotr Raczynski
2023-03-14 17:49 ` [net 03/14] net/mlx5: Fix setting ec_function bit in MANAGE_PAGES Saeed Mahameed
2023-03-15 13:10 ` Piotr Raczynski
2023-03-15 20:51 ` Saeed Mahameed
2023-03-15 21:04 ` Jakub Kicinski
2023-03-15 21:09 ` Saeed Mahameed
2023-03-15 21:33 ` Jakub Kicinski
2023-03-15 22:53 ` Saeed Mahameed [this message]
2023-03-14 17:49 ` [net 04/14] net/mlx5: Disable eswitch before waiting for VF pages Saeed Mahameed
2023-03-15 12:51 ` Piotr Raczynski
2023-03-14 17:49 ` [net 05/14] net/mlx5: E-switch, Fix wrong usage of source port rewrite in split rules Saeed Mahameed
2023-03-14 17:49 ` [net 06/14] net/mlx5: E-switch, Fix missing set of split_count when forward to ovs internal port Saeed Mahameed
2023-03-14 17:49 ` [net 07/14] net/mlx5e: Fix cleanup null-ptr deref on encap lock Saeed Mahameed
2023-03-14 17:49 ` [net 08/14] net/mlx5e: kTLS, Fix missing error unwind on unsupported cipher type Saeed Mahameed
2023-03-14 17:49 ` [net 09/14] net/mlx5: Set BREAK_FW_WAIT flag first when removing driver Saeed Mahameed
2023-03-14 17:49 ` [net 10/14] net/mlx5e: Lower maximum allowed MTU in XSK to match XDP prerequisites Saeed Mahameed
2023-03-14 17:49 ` [net 11/14] net/sched: TC, fix raw counter initialization Saeed Mahameed
2023-03-14 17:49 ` [net 12/14] net/mlx5e: TC, fix missing error code Saeed Mahameed
2023-03-14 17:49 ` [net 13/14] net/mlx5e: TC, fix cloned flow attribute Saeed Mahameed
2023-03-14 17:49 ` [net 14/14] net/mlx5e: TC, Remove error message log print Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBJMcw2i+6ijmmmA@x130 \
--to=saeed@kernel.org \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=piotr.raczynski@intel.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.