From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C161C6FD1F for ; Thu, 16 Mar 2023 06:05:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 59A131151; Thu, 16 Mar 2023 07:04:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 59A131151 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678946735; bh=ww0ZocYsI+02bKy+ETdHwsgDsAG5ndYxat5xHnfTfiI=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Qf8VJgHfamQtX09nLZJeOGECIBOwtiPD4fQ2gVorkHx1Kk6Qk0ObWguDcVx8sNnHp M2yx75DSQKOwOgT/LF8HByW9hUirkCfDbDXbRERQ/uLs2yAPU2W6Kb2Il6+DM8/oj6 n920nk3JgbWnTijzL7pVNQ4GFX5qjLFOD1qEudXk= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D2028F804B1; Thu, 16 Mar 2023 07:04:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 21E83F80423; Thu, 16 Mar 2023 07:03:52 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 792AAF80272 for ; Thu, 16 Mar 2023 07:03:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 792AAF80272 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=b4VG7dnf Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EA378B81F15; Thu, 16 Mar 2023 06:03:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D33CC433D2; Thu, 16 Mar 2023 06:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678946621; bh=ww0ZocYsI+02bKy+ETdHwsgDsAG5ndYxat5xHnfTfiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b4VG7dnf/DqeAEPohsBa/rE5su759zx0QSzs+nvK/FkE6yTEKDy6VdaHXfJVb8ATZ xsn/DNhc70ePNYS/OAHJKbwIJnHR1Co1kUHYHu/2TgNAjVT8AEGaFj2WgrdMBRsYWc 1ue1ia4lNt1ptuNMA+86kZw7jrB34vNFFmTy3lgc+kzu54cuMpDytmf3xG2Asf+hho WCuGj/pwFoAB6kdugkw2UiWGoe5qho7yJK9eBfgjmtWrMPzUt4Q4sGQes/pp0ubxpD 7ujHyh9zjfX+ShBA+ZVl7xwj22vCzYDwjavZyPL4imnPREJT5O8cxMoSgwkdZ8GM9t ZLDhWjltcGZ/A== Date: Thu, 16 Mar 2023 11:33:37 +0530 From: Vinod Koul To: Bard Liao Subject: Re: [PATCH] soundwire: stream: restore cumulative bus bandwidth when compute_params callback failed Message-ID: References: <20230316013041.1008003-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316013041.1008003-1-yung-chuan.liao@linux.intel.com> Message-ID-Hash: 5RHQPP2ER2HHYID2T4VXW726KIC6S62N X-Message-ID-Hash: 5RHQPP2ER2HHYID2T4VXW726KIC6S62N X-MailFrom: vkoul@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 16-03-23, 09:30, Bard Liao wrote: > From: Shuming Fan > > The _sdw_prepare_stream function just returns the error code when > compute_params callback failed. > The cumulative bus bandwidth will keep the value and won't be decreased > by sdw_deprepare_stream function. > We should restore the value of cumulative bus bandwidth when > compute_params callback failed. Applied, thanks -- ~Vinod