All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Qais Yousef <qyousef@layalina.io>
Cc: stable@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH 0/7] Backport uclamp vs margin fixes into 5.15.y
Date: Thu, 16 Mar 2023 08:43:58 +0100	[thread overview]
Message-ID: <ZBLIvuqi0LYWIPBN@kroah.com> (raw)
In-Reply-To: <20230315125304.g6yuhltvewnfneqs@airbuntu>

On Wed, Mar 15, 2023 at 12:53:04PM +0000, Qais Yousef wrote:
> On 03/15/23 09:53, Greg KH wrote:
> > On Wed, Mar 15, 2023 at 09:03:45AM +0100, Greg KH wrote:
> > > On Wed, Mar 08, 2023 at 04:22:00PM +0000, Qais Yousef wrote:
> > > > Portion of the fixes were ported in 5.15 but missed some.
> > > > 
> > > > This ports the remainder of the fixes.
> > > > 
> > > > Based on 5.15.98.
> > > > 
> > > > Build tested on x86 with and without uclamp config enabled.
> > > 
> > > Now queued up, thanks.
> > 
> > Wait, should we also queue up a2e90611b9f4 ("sched/fair: Remove capacity
> > inversion detection") to 5.10 and 5.15 now as well?
> 
> It has a dependency on e5ed0550c04c ("sched/fair: unlink misfit task from cpu
> overutilized") which is nice to have but not strictly required. It improves the
> search for best CPU under adverse thermal pressure to try harder. And the new
> search effectively replaces the capacity inversion detection, so it is removed
> afterwards.
> 
> I'd like to have it but find_energy_efficient_cpu() looks a bit different for
> a straightforward backport and opted to avoid the risk.
> 
> Happy to reconsider though.

Ok, just wanting to verify as that commit looked like it was needed
after these.

But, as I've just now dropped both 5.10.y and 5.15.y sets of patches,
this is going to need to be redone anyway, so perhaps put that note in
the 00/XX email when you resubmit so that I don't get confused again.

thanks,

greg k-h

  reply	other threads:[~2023-03-16  7:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 16:22 [PATCH 0/7] Backport uclamp vs margin fixes into 5.15.y Qais Yousef
2023-03-08 16:22 ` [PATCH 1/7] sched/uclamp: Fix fits_capacity() check in feec() Qais Yousef
2023-03-08 16:22 ` [PATCH 2/7] sched/uclamp: Make cpu_overutilized() use util_fits_cpu() Qais Yousef
2023-03-08 16:22 ` [PATCH 3/7] sched/uclamp: Cater for uclamp in find_energy_efficient_cpu()'s early exit condition Qais Yousef
2023-03-08 16:22 ` [PATCH 4/7] sched/fair: Detect capacity inversion Qais Yousef
2023-03-08 16:22 ` [PATCH 5/7] sched/fair: Consider capacity inversion in util_fits_cpu() Qais Yousef
2023-03-08 16:22 ` [PATCH 6/7] sched/uclamp: Fix a uninitialized variable warnings Qais Yousef
2023-03-08 16:22 ` [PATCH 7/7] sched/fair: Fixes for capacity inversion detection Qais Yousef
2023-03-15  8:03 ` [PATCH 0/7] Backport uclamp vs margin fixes into 5.15.y Greg KH
2023-03-15  8:53   ` Greg KH
2023-03-15 12:53     ` Qais Yousef
2023-03-16  7:43       ` Greg KH [this message]
2023-03-18 17:33         ` Qais Yousef
2023-03-18 19:35           ` Qais Yousef
2023-03-20 13:10             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBLIvuqi0LYWIPBN@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=stable@vger.kernel.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.