From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CF2CC6FD19 for ; Thu, 16 Mar 2023 12:50:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 46902109E; Thu, 16 Mar 2023 13:49:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 46902109E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678971041; bh=2hIIa27J4OufttFD58aRpuD3JQNUHcSmgwP80p7hQDw=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=aD6/UgTymlGGLl5WvIy7ywVtHMiiZuiHT09Z7H3e7rajTvLlVvcbhAKRkhFIcYOmG YTdohiECmmYCErruFfuDbdIscBoeHAlUTRTobYMNnr8WFeGAG4hqym3wx4upXZK8vZ rJyvxRNyQPxoDOPE0cx2ap9kbHZ6M+ucdL0JXLRg= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D39C3F80423; Thu, 16 Mar 2023 13:49:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 51ADEF80423; Thu, 16 Mar 2023 13:49:27 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A2D14F8016C for ; Thu, 16 Mar 2023 13:49:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A2D14F8016C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ZdGIneuW Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A32D8B81FCA; Thu, 16 Mar 2023 12:49:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF12BC433EF; Thu, 16 Mar 2023 12:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678970962; bh=2hIIa27J4OufttFD58aRpuD3JQNUHcSmgwP80p7hQDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZdGIneuWnom/b6edum2ICmxf9259ZsE/zcc1wnP4XX4bt94xlSUpUokRxEBTgpnYZ dvlD06MCX34+PpBfnp7xcrc86g7kv3zVy09Gut1+RdEnEYmURFLNAdBU3QNFWN9zYi PaWIinxcjc6N6f2VVRl7oCs5TGb54Om9vhaHJ7rE= Date: Thu, 16 Mar 2023 13:49:19 +0100 From: Greg Kroah-Hartman To: Herve Codina Subject: Re: [PATCH v2 2/7] drivers: misc: Add support for the Lantiq PEF2256 framer Message-ID: References: <20230316122741.577663-1-herve.codina@bootlin.com> <20230316122741.577663-3-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316122741.577663-3-herve.codina@bootlin.com> Message-ID-Hash: NHRY5IAWZNAEXE4D37UIVOQZXQ6Y2K5I X-Message-ID-Hash: NHRY5IAWZNAEXE4D37UIVOQZXQ6Y2K5I X-MailFrom: gregkh@linuxfoundation.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Mar 16, 2023 at 01:27:36PM +0100, Herve Codina wrote: > +EXPORT_SYMBOL(pef2256_get_byphandle); You have a mixture of EXPORT_SYMBOL() and EXPORT_SYMBOL_GPL() in the same file here. As this one: > + > +void pef2256_put(struct pef2256 *pef2256) > +{ > + put_device(pef2256->dev); > +} > +EXPORT_SYMBOL(pef2256_put); Is just a wrapper around a EXPORT_SYMBOL_GPL() function, please revisit and perhaps make them all EXPORT_SYMBOL_GPL() calls? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E3B9C6FD1F for ; Thu, 16 Mar 2023 12:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbjCPMtZ (ORCPT ); Thu, 16 Mar 2023 08:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbjCPMtY (ORCPT ); Thu, 16 Mar 2023 08:49:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 710FE36FEA; Thu, 16 Mar 2023 05:49:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E37D362000; Thu, 16 Mar 2023 12:49:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF12BC433EF; Thu, 16 Mar 2023 12:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678970962; bh=2hIIa27J4OufttFD58aRpuD3JQNUHcSmgwP80p7hQDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZdGIneuWnom/b6edum2ICmxf9259ZsE/zcc1wnP4XX4bt94xlSUpUokRxEBTgpnYZ dvlD06MCX34+PpBfnp7xcrc86g7kv3zVy09Gut1+RdEnEYmURFLNAdBU3QNFWN9zYi PaWIinxcjc6N6f2VVRl7oCs5TGb54Om9vhaHJ7rE= Date: Thu, 16 Mar 2023 13:49:19 +0100 From: Greg Kroah-Hartman To: Herve Codina Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v2 2/7] drivers: misc: Add support for the Lantiq PEF2256 framer Message-ID: References: <20230316122741.577663-1-herve.codina@bootlin.com> <20230316122741.577663-3-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316122741.577663-3-herve.codina@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 16, 2023 at 01:27:36PM +0100, Herve Codina wrote: > +EXPORT_SYMBOL(pef2256_get_byphandle); You have a mixture of EXPORT_SYMBOL() and EXPORT_SYMBOL_GPL() in the same file here. As this one: > + > +void pef2256_put(struct pef2256 *pef2256) > +{ > + put_device(pef2256->dev); > +} > +EXPORT_SYMBOL(pef2256_put); Is just a wrapper around a EXPORT_SYMBOL_GPL() function, please revisit and perhaps make them all EXPORT_SYMBOL_GPL() calls? thanks, greg k-h