From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 275CC29A2 for ; Thu, 16 Mar 2023 18:38:53 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1a04bd0ab07so153775ad.1 for ; Thu, 16 Mar 2023 11:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678991932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Aco+48KQSTXrRgbQkuc+78HSNv7058GW4RTMfCAnIHA=; b=oVgVVSr3DpFodH/W7BEB8twr3ljYV/n6IfeeSQNw2KZSVWn1wUlErVeZyZDxN7u8ah 2WLpPfc07KAV4brUvbTfPm1hD3Xl+hniedRD6YoZwmdJnHxLU3Bt3lNfQifmAXLABFLJ yi726pxGiBD/0r1OCjCb+3jxdD/Z8yI18AbzOVHfNHBWSeTOhNTW5O4VDQJLJfTPCEPV UGNCKJn7qZHYmmfSHQqd+N6V7+nWV9V1HCwi4y0gELcQWwJxYnUiK+vDt6kuXP2DodMY ubo1Iu2Ne1uES2/k/MkJwG8dzRBJw9vbfrqXv2L1n913ZJcftiop3F3bcmZisfGTDtyW gZyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678991932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Aco+48KQSTXrRgbQkuc+78HSNv7058GW4RTMfCAnIHA=; b=l87PldEPm/fU/geX2+KdbrYfqqOa6IBkV4/hX4pc9i8p7YwG1mSzElVz4Iozcg0Wd3 Re9fZBMeNctzBHZHtHe8caKhnMOxvPMC3zBHKCVHNCIL4jYgtC9kxR4Cu2BV597gxSxV zPa7yqkIt/N+M9kJ1d1Jkvo5kJblspOcDwJHZ8p3nCj3jf86XdWCkN0rvp+WqEbpuQOM 2X4hO3fIoLWlgtQtAJbCNrBU2OUTbAcHTXmiesftusApzwMjjPrRilutqiCt77xQRJsp 3E+ufojLRjRjS+61zSNYfU/LO0IOiL5/XblKugTvVG4OZpd6xHdAn5HPSoQcQTTmdVXx Fu1Q== X-Gm-Message-State: AO0yUKXfZfZx2wrU/OGQrqZFJNRxbreCzRV46uGFx1q3KW+pY4lW+q4n Y+/IW5Rajp4/Bi9eN8mOr4bNfg== X-Google-Smtp-Source: AK7set8t8uixLTKQFPibXI9O3Eyr3dYB1pWE4h2zKgCpwhJYghtHW0myy/GlG+JZ/ZkMAVXYVektCg== X-Received: by 2002:a17:902:dac6:b0:199:3909:eaee with SMTP id q6-20020a170902dac600b001993909eaeemr26571plx.6.1678991932413; Thu, 16 Mar 2023 11:38:52 -0700 (PDT) Received: from google.com ([2620:15c:2d:3:c641:8e37:69f3:8d4c]) by smtp.gmail.com with ESMTPSA id w5-20020a1709029a8500b001a064cff3c5sm44886plp.43.2023.03.16.11.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 11:38:51 -0700 (PDT) Date: Thu, 16 Mar 2023 11:38:47 -0700 From: Isaac Manjarres To: Catalin Marinas Cc: Linus Torvalds , Arnd Bergmann , Christoph Hellwig , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Robin Murphy , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 00/13] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Message-ID: References: <20221106220143.2129263-1-catalin.marinas@arm.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221106220143.2129263-1-catalin.marinas@arm.com> On Sun, Nov 06, 2022 at 10:01:30PM +0000, Catalin Marinas wrote: > Patches 7-12 change some ARCH_KMALLOC_MINALIGN uses to > ARCH_DMA_MINALIGN. The crypto changes have been rejected by Herbert > previously but I still included them here until the crypto code is > refactored. Hi Catalin, Herbert merged the changes to the crypto code that were required to be able to safely lower the minimum alignment for kmalloc in [1]. Given this, I don't think there's anything blocking this series from being merged. The requirement for SWIOTLB to get to the minimum kmalloc alignment down to 8 bytes shouldn't prevent this series from being merged, as the amount of memory that is allocated for SWIOTLB can be configured through the commandline to minimize the impact of having SWIOTLB memory. Additionally, even if no SWIOTLB is present, this series still offers memory savings on a lot of ARM64 platforms by using the cache line size as the minimum alignment for kmalloc. Can you please rebase this series so that it can be merged? Thanks, Isaac [1]: https://lore.kernel.org/all/Y4nDL50nToBbi4DS@gondor.apana.org.au/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 153FEC6FD19 for ; Thu, 16 Mar 2023 18:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5klorKnUPuhaRtgV1Y97/LrF47SK/kDETmNwCJ4EUx8=; b=DsvQ7L02OX4SFe 5bMZ222Rv5ckZGL1THLSpzip1qpKcvpgGg+DyxlPwOmvYBneA+S/cfF3S2HkRi+F9CuxOI7TXAhxo Oe/W95K9qAB1MUIo9jjhXw7hFx0a8eU5cQeFMKeH9YX5ksbKNetY+vwQ9FcQDE6DNzb80rTHlfzZx e0KgCKYph4nR+hzl9d2CBGjHw0GtIenpF0r1yAFS6zm9kxE9h70m1Zdk93L2VZAr/s+kkSOzcpZSP hswZr9hOZo+NHDr8+jShw6e/7wi3PEEI+D2+a/LpZl5W4X6pwZEMq8p3WrpuH0pNWbWfNx6eZU/4w fyt6y1ITdr/v2zB5wVBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcsVD-00HGxD-2b; Thu, 16 Mar 2023 18:39:03 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcsVA-00HGum-1U for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 18:39:01 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1a19cf1b8ddso20705ad.0 for ; Thu, 16 Mar 2023 11:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678991932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Aco+48KQSTXrRgbQkuc+78HSNv7058GW4RTMfCAnIHA=; b=oVgVVSr3DpFodH/W7BEB8twr3ljYV/n6IfeeSQNw2KZSVWn1wUlErVeZyZDxN7u8ah 2WLpPfc07KAV4brUvbTfPm1hD3Xl+hniedRD6YoZwmdJnHxLU3Bt3lNfQifmAXLABFLJ yi726pxGiBD/0r1OCjCb+3jxdD/Z8yI18AbzOVHfNHBWSeTOhNTW5O4VDQJLJfTPCEPV UGNCKJn7qZHYmmfSHQqd+N6V7+nWV9V1HCwi4y0gELcQWwJxYnUiK+vDt6kuXP2DodMY ubo1Iu2Ne1uES2/k/MkJwG8dzRBJw9vbfrqXv2L1n913ZJcftiop3F3bcmZisfGTDtyW gZyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678991932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Aco+48KQSTXrRgbQkuc+78HSNv7058GW4RTMfCAnIHA=; b=bUr+6wkfmIEXwB18e0ZtqXjTeiZKpdzbrJaXkF7XRBgYan//ouGeiMalq+4tml5uQu Y5HF1n0HafnrdSP/LD4X/ILpwxZQf91wrqAbMUvMPw6mkwry4ZjeBNws2ZPAr0BCgrvs AJwFB92PASKH5GopNJtmvfsX0JUTBYBBUYo+bEyjdckGzaS4EtoTFbrUUj5YMq4fc9bZ vDkNh77u2Pndmu1Dl8o03fHVFwcUy8qnPLKgc3C+HjmO8LT+zut8sONy+ZYihOQF6xVI MmPuaLg3om8+8/buVoHAewNm1a5KwyU1Bj17Gd+mni8U3fecOCgJ7aMarJZDG2qqhWCS 958g== X-Gm-Message-State: AO0yUKV8ID1ax4ZrZ4ry2tl8xwQeHRVugH33s0izE68gJfDwlCz/fP9q isZ0GkJ33vsino8xZs7ESLlxKlyYv+Rne61welcpmg43 X-Google-Smtp-Source: AK7set8t8uixLTKQFPibXI9O3Eyr3dYB1pWE4h2zKgCpwhJYghtHW0myy/GlG+JZ/ZkMAVXYVektCg== X-Received: by 2002:a17:902:dac6:b0:199:3909:eaee with SMTP id q6-20020a170902dac600b001993909eaeemr26571plx.6.1678991932413; Thu, 16 Mar 2023 11:38:52 -0700 (PDT) Received: from google.com ([2620:15c:2d:3:c641:8e37:69f3:8d4c]) by smtp.gmail.com with ESMTPSA id w5-20020a1709029a8500b001a064cff3c5sm44886plp.43.2023.03.16.11.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 11:38:51 -0700 (PDT) Date: Thu, 16 Mar 2023 11:38:47 -0700 From: Isaac Manjarres To: Catalin Marinas Cc: Linus Torvalds , Arnd Bergmann , Christoph Hellwig , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Robin Murphy , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 00/13] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Message-ID: References: <20221106220143.2129263-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221106220143.2129263-1-catalin.marinas@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_113900_501182_E0B5ED31 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 06, 2022 at 10:01:30PM +0000, Catalin Marinas wrote: > Patches 7-12 change some ARCH_KMALLOC_MINALIGN uses to > ARCH_DMA_MINALIGN. The crypto changes have been rejected by Herbert > previously but I still included them here until the crypto code is > refactored. Hi Catalin, Herbert merged the changes to the crypto code that were required to be able to safely lower the minimum alignment for kmalloc in [1]. Given this, I don't think there's anything blocking this series from being merged. The requirement for SWIOTLB to get to the minimum kmalloc alignment down to 8 bytes shouldn't prevent this series from being merged, as the amount of memory that is allocated for SWIOTLB can be configured through the commandline to minimize the impact of having SWIOTLB memory. Additionally, even if no SWIOTLB is present, this series still offers memory savings on a lot of ARM64 platforms by using the cache line size as the minimum alignment for kmalloc. Can you please rebase this series so that it can be merged? Thanks, Isaac [1]: https://lore.kernel.org/all/Y4nDL50nToBbi4DS@gondor.apana.org.au/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel