All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Xiangyu Chen <xiangyu.chen@eng.windriver.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][kirkstone][PATCH 0/2] fix the template of lxc download failure on kirkstone
Date: Fri, 17 Mar 2023 15:33:03 -0400	[thread overview]
Message-ID: <ZBTAb7w8Z5gKFeGo@gmail.com> (raw)
In-Reply-To: <20230317102829.3833398-1-xiangyu.chen@eng.windriver.com>

In message: [meta-virtualization][kirkstone][PATCH 0/2] fix the template of lxc download failure on kirkstone
on 17/03/2023 Xiangyu Chen wrote:

> From: Xiangyu Chen <xiangyu.chen@windriver.com>
> 
> Hi Bruce,
> 
> This series of patch to fix the template of lxc-download on kirkstone.
> 
> When we using a download container command[1], the lxc-create would report missing 
> "fi" error, this has been already fixed on master, so backport those changes in 
> templates-use-curl-instead-of-wget.patch to kirkstone.
> 
> 05f316f70a4d : lxc: update to 5.x and meson
> 211918936180 : treewide: bulk update patches with status field
> 
> After backport those changes, the lxc-create with download template still has 
> failure, after checking the image website url, it was redirected to a mirror
> site, so curl need to add a -L option to support url redirect, the version of 
> curl in kirkstone also need to add an option -f to use return an error code to 
> tell the caller when http/https has errors.

Thanks for the explanation, you answered my questions about
"is this an issue in master" and "why aren't these just cherr picks".

These are merged to kirkstone.

Bruce

> 
> 
> [1] lxc-create -t download -n test -- --dist archlinux --release current --arch arm64
> 
> 
> Xiangyu Chen (2):
>   lxc: backport changes from master for
>     templates-use-curl-instead-of-wget.patch
>   lxc: add -L and -f for curl in
>     templates-use-curl-instead-of-wget.patch
> 
>  .../templates-use-curl-instead-of-wget.patch  | 40 ++++++++++---------
>  1 file changed, 21 insertions(+), 19 deletions(-)
> 
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7943): https://lists.yoctoproject.org/g/meta-virtualization/message/7943
> Mute This Topic: https://lists.yoctoproject.org/mt/97669932/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      parent reply	other threads:[~2023-03-17 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 10:28 [meta-virtualization][kirkstone][PATCH 0/2] fix the template of lxc download failure on kirkstone Xiangyu Chen
2023-03-17 10:28 ` [meta-virtualization][kirkstone][PATCH 1/2] lxc: backport changes from master for templates-use-curl-instead-of-wget.patch Xiangyu Chen
2023-03-17 10:28 ` [meta-virtualization][kirkstone][PATCH 2/2] lxc: add -L and -f for curl in templates-use-curl-instead-of-wget.patch Xiangyu Chen
2023-03-17 19:33 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBTAb7w8Z5gKFeGo@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=xiangyu.chen@eng.windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.