From: Dave Chinner <david@fromorbit.com>
To: Catherine Hoang <catherine.hoang@oracle.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v1 0/4] setting uuid of online filesystems
Date: Sun, 19 Mar 2023 11:16:48 +1100 [thread overview]
Message-ID: <ZBZUcGLcTSgKVXa5@destitution> (raw)
In-Reply-To: <953CAB5C-E645-4BB2-88E2-E992C5CC565D@oracle.com>
On Thu, Mar 16, 2023 at 08:41:14PM +0000, Catherine Hoang wrote:
> > On Mar 13, 2023, at 11:28 PM, Dave Chinner <david@fromorbit.com> wrote:
> >
> > On Mon, Mar 13, 2023 at 09:21:05PM -0700, Catherine Hoang wrote:
> >> Hi all,
> >>
> >> This series of patches implements a new ioctl to set the uuid of mounted
> >> filesystems. Eventually this will be used by the 'xfs_io fsuuid' command
> >> to allow userspace to update the uuid.
> >>
> >> Comments and feedback appreciated!
> >
> > What's the use case for this?
>
> We want to be able to change the uuid on newly mounted clone vm images
> so that each deployed system has a different uuid. We need to do this the
> first time the system boots, but after the root fs is mounted so that fsuuid
> can run in parallel with other service startup to minimize deployment times.
Why can't you do it offline immediately after the offline clone of
the golden image? I mean, cloning images and setting up their
contents is something the external orchestration software does
and will always have to do, so i don't really understand why UUID
needs to be modified at first mount vs at clone time. Can you
describe why it actually needs to be done after first mount?
> >> xfs: add XFS_IOC_SETFSUUID ioctl
> >> xfs: export meta uuid via xfs_fsop_geom
> >
> > For what purpose does userspace ever need to know the sb_meta_uuid?
>
> Userspace would need to know the meta uuid if we want to restore
> the original uuid after it has been changed.
I don't understand why you'd want to restore the original UUID given
the use case you've describe. Can you explain the situation where
you want to return a cloned image to the original golden image UUID?
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-03-19 0:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 4:21 [PATCH v1 0/4] setting uuid of online filesystems Catherine Hoang
2023-03-14 4:21 ` [PATCH v1 1/4] xfs: refactor xfs_uuid_mount and xfs_uuid_unmount Catherine Hoang
2023-03-14 4:21 ` [PATCH v1 2/4] xfs: implement custom freeze/thaw functions Catherine Hoang
2023-03-14 5:11 ` Amir Goldstein
2023-03-14 5:25 ` Darrick J. Wong
2023-03-14 6:00 ` Amir Goldstein
2023-03-16 5:16 ` Darrick J. Wong
2023-03-14 4:21 ` [PATCH v1 3/4] xfs: add XFS_IOC_SETFSUUID ioctl Catherine Hoang
2023-03-14 5:50 ` Amir Goldstein
2023-03-15 23:12 ` Catherine Hoang
2023-03-16 8:09 ` Amir Goldstein
2023-03-18 0:39 ` Darrick J. Wong
2023-03-18 9:31 ` Amir Goldstein
2023-03-14 4:21 ` [PATCH v1 4/4] xfs: export meta uuid via xfs_fsop_geom Catherine Hoang
2023-03-14 6:28 ` [PATCH v1 0/4] setting uuid of online filesystems Dave Chinner
2023-03-16 20:41 ` Catherine Hoang
2023-03-19 0:16 ` Dave Chinner [this message]
2023-03-28 1:38 ` Darrick J. Wong
2023-03-18 0:11 ` Darrick J. Wong
2023-03-18 9:04 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBZUcGLcTSgKVXa5@destitution \
--to=david@fromorbit.com \
--cc=catherine.hoang@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.