From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Jeff LaBundy <jeff@labundy.com>,
linux-input@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] Input: iqs62x-keys - Suppress duplicated error message in .remove()
Date: Sun, 19 Mar 2023 21:28:53 -0700 [thread overview]
Message-ID: <ZBfhBUzU0THfTT3I@google.com> (raw)
In-Reply-To: <20230318225110.261439-1-u.kleine-koenig@pengutronix.de>
On Sat, Mar 18, 2023 at 11:51:10PM +0100, Uwe Kleine-König wrote:
> If a platform driver's remove callback returns non-zero the driver core
> emits an error message. In such a case however iqs62x_keys_remove()
> already issued a (better) message. So return zero to suppress the
> generic message.
>
> This patch has no other side effects as platform_remove() ignores the
> return value of .remove() after the warning.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2023-03-20 4:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 22:51 [PATCH] Input: iqs62x-keys - Suppress duplicated error message in .remove() Uwe Kleine-König
2023-03-20 4:28 ` Dmitry Torokhov [this message]
2023-03-27 23:27 ` Jeff LaBundy
2023-03-28 6:08 ` Uwe Kleine-König
2023-03-29 2:00 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBfhBUzU0THfTT3I@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=mkorpershoek@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.