From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Matthias Benkmann <matthias.benkmann@gmail.com>,
linux-input@vger.kernel.org, Nate Yocom <nate@yocom.org>,
hadess@hadess.net, benjamin.tissoires@redhat.com,
linux-kernel@vger.kernel.org, Pavel Rojtberg <rojtberg@gmail.com>
Subject: Re: [PATCH v3] Fix incorrectly applied patch for MAP_PROFILE_BUTTON
Date: Sun, 19 Mar 2023 21:33:45 -0700 [thread overview]
Message-ID: <ZBfiKc2IHtonxy7o@google.com> (raw)
In-Reply-To: <20230318180047.3pzcep5roaon3nph@intel.intel>
On Sat, Mar 18, 2023 at 07:00:47PM +0100, Andi Shyti wrote:
> On Sat, Mar 18, 2023 at 04:21:06PM +0100, Matthias Benkmann wrote:
> > When the linked patch was applied,
>
> Please refer to the patch as "commit fff1011a26d6 ("Input: xpad -
> add X-Box Adaptive Profile button")" and not as "linked patch".
>
> > one hunk ended up in the wrong function. This patch moves it to where
> > it probably belongs.
>
> probably? We need to be sure here :)
>
> Besides, please, use the imperative form, not "this patch moves"
> but "move what where", please be more specific.
Reworded and applied, thank you.
--
Dmitry
prev parent reply other threads:[~2023-03-20 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 14:41 [PATCH v2] Fix incorrectly applied patch for MAP_PROFILE_BUTTON Matthias Benkmann
2023-03-18 15:21 ` [PATCH v3] " Matthias Benkmann
2023-03-18 18:00 ` Andi Shyti
2023-03-20 4:33 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBfiKc2IHtonxy7o@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.benkmann@gmail.com \
--cc=nate@yocom.org \
--cc=rojtberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.