From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 00/14] drm/i915/tc: Fix a few TypeC / MST issues
Date: Mon, 20 Mar 2023 22:19:05 +0200 [thread overview]
Message-ID: <ZBi/uVMhXNIqP5UU@intel.com> (raw)
In-Reply-To: <20230316131724.359612-1-imre.deak@intel.com>
On Thu, Mar 16, 2023 at 03:17:10PM +0200, Imre Deak wrote:
> This patchset fixes a few issues on TypeC ports, related to the legacy
> port handling, HW state readout/verification. It also fixes an issue on
> TC port/MST outputs during system suspend/resume, where the modeset
> restoring the pre-suspend state fails atm.
>
> Tested on ICL, TGL, ADLP.
>
> Imre Deak (14):
> drm/i915/tc: Abort DP AUX transfer on a disconnected TC port
> drm/i915/tc: Fix TC port link ref init for DP MST during HW readout
> drm/i915/tc: Fix the ICL PHY ownership check in TC-cold state
> drm/i915/tc: Fix system resume MST mode restore for DP-alt sinks
> drm/i915/tc: Wait for IOM/FW PHY initialization of legacy TC ports
> drm/i915/tc: Factor out helpers converting HPD mask to TC mode
> drm/i915/tc: Fix target TC mode for a disconnected legacy port
> drm/i915/tc: Fix TC mode for a legacy port if the PHY is not ready
> drm/i915/tc: Fix initial TC mode on disabled legacy ports
> drm/i915/tc: Make the TC mode readout consistent in all PHY states
> drm/i915/tc: Assume a TC port is legacy if VBT says the port has HDMI
> drm/i915: Add encoder hook to get the PLL type used by TC ports
> drm/i915/tc: Factor out a function querying active links on a TC port
> drm/i915/tc: Check the PLL type used by an enabled TC port
Read through it and didn't spot anything egregious. Just a few
minor nits for which I replied separately.
Apart from those the series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drivers/gpu/drm/i915/display/intel_ddi.c | 44 ++-
> drivers/gpu/drm/i915/display/intel_ddi.h | 3 +
> .../drm/i915/display/intel_display_types.h | 6 +
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 15 +-
> drivers/gpu/drm/i915/display/intel_tc.c | 319 ++++++++++++++----
> drivers/gpu/drm/i915/display/intel_tc.h | 1 +
> 6 files changed, 320 insertions(+), 68 deletions(-)
>
> --
> 2.37.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-03-20 20:19 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 13:17 [Intel-gfx] [PATCH 00/14] drm/i915/tc: Fix a few TypeC / MST issues Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 01/14] drm/i915/tc: Abort DP AUX transfer on a disconnected TC port Imre Deak
2023-03-21 11:09 ` Kahola, Mika
2023-03-21 13:45 ` Imre Deak
2023-03-22 11:19 ` Andrzej Hajda
2023-03-22 12:04 ` Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 02/14] drm/i915/tc: Fix TC port link ref init for DP MST during HW readout Imre Deak
2023-03-21 12:06 ` Kahola, Mika
2023-03-21 14:00 ` Imre Deak
2023-03-24 7:03 ` Kahola, Mika
2023-03-16 13:17 ` [Intel-gfx] [PATCH 03/14] drm/i915/tc: Fix the ICL PHY ownership check in TC-cold state Imre Deak
2023-03-16 13:51 ` Souza, Jose
2023-03-16 13:17 ` [Intel-gfx] [PATCH 04/14] drm/i915/tc: Fix system resume MST mode restore for DP-alt sinks Imre Deak
2023-03-20 20:16 ` Ville Syrjälä
2023-03-20 21:36 ` Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 05/14] drm/i915/tc: Wait for IOM/FW PHY initialization of legacy TC ports Imre Deak
2023-03-24 8:14 ` Kahola, Mika
2023-03-16 13:17 ` [Intel-gfx] [PATCH 06/14] drm/i915/tc: Factor out helpers converting HPD mask to TC mode Imre Deak
2023-03-24 8:16 ` Kahola, Mika
2023-03-16 13:17 ` [Intel-gfx] [PATCH 07/14] drm/i915/tc: Fix target TC mode for a disconnected legacy port Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 08/14] drm/i915/tc: Fix TC mode for a legacy port if the PHY is not ready Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 09/14] drm/i915/tc: Fix initial TC mode on disabled legacy ports Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 10/14] drm/i915/tc: Make the TC mode readout consistent in all PHY states Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 11/14] drm/i915/tc: Assume a TC port is legacy if VBT says the port has HDMI Imre Deak
2023-03-20 20:01 ` Ville Syrjälä
2023-03-20 21:33 ` Imre Deak
2023-03-21 22:00 ` [Intel-gfx] [PATCH v2 " Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 12/14] drm/i915: Add encoder hook to get the PLL type used by TC ports Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 13/14] drm/i915/tc: Factor out a function querying active links on a TC port Imre Deak
2023-03-20 20:05 ` Ville Syrjälä
2023-03-20 21:34 ` Imre Deak
2023-03-21 22:01 ` [Intel-gfx] [PATCH v2 " Imre Deak
2023-03-16 13:17 ` [Intel-gfx] [PATCH 14/14] drm/i915/tc: Check the PLL type used by an enabled " Imre Deak
2023-03-21 22:01 ` [Intel-gfx] [PATCH v2 " Imre Deak
2023-03-16 22:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tc: Fix a few TypeC / MST issues Patchwork
2023-03-17 8:54 ` Imre Deak
2023-03-20 20:19 ` Ville Syrjälä [this message]
2023-03-20 21:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: Fix a few TypeC / MST issues (rev2) Patchwork
2023-03-20 21:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-20 21:48 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-20 21:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-21 2:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-21 22:16 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/tc: Fix a few TypeC / MST issues (rev5) Patchwork
2023-03-21 22:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: " Patchwork
2023-03-21 22:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-21 22:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-03-21 23:43 ` Imre Deak
2023-03-22 9:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: Fix a few TypeC / MST issues (rev6) Patchwork
2023-03-22 9:45 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-22 9:45 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-22 10:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-22 15:07 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-22 18:38 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBi/uVMhXNIqP5UU@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.