From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3398C6FD1D for ; Mon, 20 Mar 2023 16:32:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232299AbjCTQb7 (ORCPT ); Mon, 20 Mar 2023 12:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231968AbjCTQbj (ORCPT ); Mon, 20 Mar 2023 12:31:39 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A2288680 for ; Mon, 20 Mar 2023 09:24:25 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id n8-20020a17090a2bc800b0023f06808981so4549477pje.8 for ; Mon, 20 Mar 2023 09:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679329465; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=aVYMsUe392bOA51AaoYinxkg/ZveVBCWl2uURIaoZUU=; b=U++x0RG2aQLbQMI+FZObbfICiQioNipfz53TOkUdevZvfpZuOa5qEQbovybb+DF6Yy 2+b2YFT1TvrrzI6Xgh0byuCKWVeuWWSyq3qEcGA0O1tVYeHXE011kIzdh0c65SvSsT8B DPzWShnEyF3wF06wJRVnmt4HyeCJ65bm8JYx/tNzNfjlNAIoN88WAWwrwBhKgAydZFXK ETzlYD/fCphCSmsvjNNvMwIKetngDZ0R0fmxMsRnFjgz2wWI0aDRrvIUV1aO5yyFM/4+ 3tb2rBO3bIg+lnWlakzLfUgke4YWxkyaVK9d8Ds5ea8KRpYlwUQ3esLBLcm+oHULqPDO FPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679329465; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aVYMsUe392bOA51AaoYinxkg/ZveVBCWl2uURIaoZUU=; b=XTssznoXZOplrGV63Tuf6jI5qBRJkS482DBXiiWbxJQAwPPgtmf3cLoWLU25sDCAjS BCX9NTmZG3p21qtmBqWBdYzCz+I8JLJntElk/43a5DzpjVCBLpahe10B9WqVURSdND3M pvSGSGJq4M63tB1yk5Ry+7AOHgQ+1hhBekPaYU9JZo0aUEQlD2j2IOi96Py0BUn0Vzws nn9LqMYJvI+bUiyQ76yjDOOguiQ6hFYu6erwp0h/gZcUOH7nFIuD87STgNqth1yAvie3 kAxSoF9KAWdBBnG/3C8YSOyhBc0UDGpKhIUSj33c3CEIXpnoDpkCFkDzgazvyYt+X8m8 UVKA== X-Gm-Message-State: AO0yUKUhGpxTo9WAP8hNAVau6qSJkQ8ih2MrNrRoNFsqjyjNyZCMFivS 8yXDZ8Hs4CkQVlmlCvXdgXIO11+5Oaw= X-Google-Smtp-Source: AK7set9Dz5tG1ZIPCM3pJnvPFABnvcgBw4GGwXpg+AprPTddlLwNkv9e6+wqSREbZn0nDbHJnaz2viPUmNQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:2d0e:b0:625:dc5b:9d1d with SMTP id fa14-20020a056a002d0e00b00625dc5b9d1dmr8347160pfb.0.1679329464895; Mon, 20 Mar 2023 09:24:24 -0700 (PDT) Date: Mon, 20 Mar 2023 09:24:23 -0700 In-Reply-To: <301c7527-6319-b993-f43f-dc61b9af4b34@redhat.com> Mime-Version: 1.0 References: <20230201132905.549148-1-eesposit@redhat.com> <20230201132905.549148-2-eesposit@redhat.com> <20230317190432.GA863767@dev-arch.thelio-3990X> <20230317225345.z5chlrursjfbz52o@desk> <20230317231401.GA4100817@dev-arch.thelio-3990X> <20230317235959.buk3y25iwllscrbe@desk> <301c7527-6319-b993-f43f-dc61b9af4b34@redhat.com> Message-ID: Subject: Re: [PATCH 1/3] kvm: vmx: Add IA32_FLUSH_CMD guest support From: Sean Christopherson To: Emanuele Giuseppe Esposito Cc: Pawan Gupta , Nathan Chancellor , kvm@vger.kernel.org, Jim Mattson , Ben Serebrin , Peter Shier , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Maxim Levitsky , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Mar 20, 2023, Emanuele Giuseppe Esposito wrote: > > Am 20/03/2023 um 15:53 schrieb Sean Christopherson: > > The patches obviously weren't tested, > Well... no. They were tested. Call it wrongly tested, badly tested, > whatever you want but don't say "obviously weren't tested". Heh, depends on how you define "tested". I was defining tested as "tested to work as expected on systems with and without support for IA32_FLUSH_CMD". But yeah, I should have said "properly tested". > I even asked you in a private email why the cpu flag was visible in Linux and > not in rhel when using the same machine. > > So again, my bad with these patches, I sincerely apologize but I would > prefer that you think I don't know how to test this stuff rather than > say that I carelessly sent something without checking :) I didn't intend to imply that you didn't try to do the right thing, nor am I unhappy with you personally. My apologies if my response came off that way. What I am most grumpy about is that this series was queued without tests. E.g. unless there's a subtlety I'm missing, a very basic KVM-Unit-Test to verify that the guest can write MSR_IA32_FLUSH_CMD with L1D_FLUSH when the MSR is supported would have caught this bug. One of the reasons for requiring actual testcases is that dedicated testcases reduce the probability of "testing gone wrong", e.g. a TEST_SKIPPED would have alerted you that the KVM code wasn't actually being exercised.