From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5774C6FD1D for ; Mon, 20 Mar 2023 22:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbjCTW3T (ORCPT ); Mon, 20 Mar 2023 18:29:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbjCTW3S (ORCPT ); Mon, 20 Mar 2023 18:29:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D2DC619C; Mon, 20 Mar 2023 15:29:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 753BEB810F6; Mon, 20 Mar 2023 22:29:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04FCDC433EF; Mon, 20 Mar 2023 22:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679351352; bh=scf65u0jBdg4sE2X6WhlnAwDa/Qn0mokAtjRKzVKTBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aZUC//1LZhzPYZGH5UOU4TgPC/YD48hCJ+XuVz6zUEw2Ap+w59sv+K+pRiSKuK7qH b1QX3JSgetAwDNbXlXreAosBbAs7Qlc3nmxNOkgfoawYYn+oNbGTXZpTxaemcM0b0L oxDL5zO2I40RkzwuIEMYIWcAkCHrwrdFPZt5+1RlrXW5mQ81rVIdlkT6so0ihzQM05 BPkZ/mhJqNy7jaXB/T5AKeRFAroBlQxWi87V/sk4wONAh4uv/PE+kkM21ujCSZvErg CcELv5sT+SLNdzgVeA6GTdsTTDebiCyohXOXmunqoi+YC8dD5ZbgZ75o5V4WbTXabR xp+D1oMZIkppw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EC8E04052D; Mon, 20 Mar 2023 19:29:09 -0300 (-03) Date: Mon, 20 Mar 2023 19:29:09 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: James Clark , linux-perf-users@vger.kernel.org, Anshuman.Khandual@arm.com, Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , John Garry , Will Deacon , Mike Leach , Leo Yan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/4] Enable display of partial and empty SVE predicates from Arm SPE data Message-ID: References: <20230320151509.1137462-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Mar 20, 2023 at 10:50:59AM -0700, Ian Rogers escreveu: > On Mon, Mar 20, 2023 at 8:15 AM James Clark wrote: > > > > Changes since v1: > > * Rebase onto perf/core because it no longer applied cleanly > > > > ------------ > > > > Hi, > > > > I'm submitting this on behalf of German who moved on to work on other > > things in Arm before he could finish it off. > > > > The predicate information is available on SPE samples from > > Armv8.3 (FEAT_SPEv1p1), this could be useful info for profiling SVE > > code as partial and empty predicates indicate that the full vector > > width isn't being used. There is a good example in the last commit > > message. > > > > Though currently, there isn't a suitable field to store the info > > on Perf samples, so this change also adds a new SIMD field. > > This field could be used by other architectures, but currently there > > is only one bit reserved to identify SVE. It's only added to > > struct perf_sample on the userspace side, and isn't part of the kernel > > ABI, so it doesn't survive a perf inject. Although this is the > > same behavior for some other fields like branch flags, so I don't > > think it should be an issue to do something similar here. Perhaps in > > the future we could make sure everything that is synthesised from > > auxtrace data also makes it back into the new Perf inject file without > > being lost. > > Series: > Acked-by: Ian Rogers Thanks, applied. - Arnaldo > Thanks, > Ian > > > German Gomez (4): > > perf event: Add simd_flags field to perf_sample > > perf arm-spe: Refactor arm-spe to support operation packet type > > perf arm-spe: Add SVE flags to the SPE samples > > perf report: Add 'simd' sort field > > > > tools/perf/Documentation/perf-report.txt | 1 + > > .../util/arm-spe-decoder/arm-spe-decoder.c | 30 ++++++++++-- > > .../util/arm-spe-decoder/arm-spe-decoder.h | 47 +++++++++++++++---- > > tools/perf/util/arm-spe.c | 28 +++++++++-- > > tools/perf/util/hist.c | 1 + > > tools/perf/util/hist.h | 1 + > > tools/perf/util/sample.h | 13 +++++ > > tools/perf/util/sort.c | 47 +++++++++++++++++++ > > tools/perf/util/sort.h | 2 + > > 9 files changed, 152 insertions(+), 18 deletions(-) > > > > > > base-commit: 96d541699e5c50b1bc2d50c83cd7145994d5f071 > > -- > > 2.34.1 > > -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CD7BC6FD1C for ; Mon, 20 Mar 2023 22:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d022KZS0EZc7Aki//BSZcEMvmFJirRMWZNIpklWQ2ws=; b=juk1ZJ5RvIi1cp 6wENabHDN9oJrN3BaxhgDBtRVlbDhNzKo38cGRiZ7HNhZ+qq+VygDQcU8mFibNVjS2pc4X94lal5I S4q4XONMrOfS0jBysgT9EIK/2VnqwaDB3gEgR7TJoA8auF4PMQHnDbmzWeQz8Rx955FPc6GHaPA85 /Kg9f+4riTZP/KarQn33Fb/jYFn0KGi030EO3N/o5a/tMKH7TxUuTuhgFfU14G9Dt7mPUWxdqS/kC lCCp9NDmyvXXZBemiUQ406j1pSR5+tfH/oL5wWEg//oOA94WH53Qk5GSj7fVXBoipdp8vhalrtMCx ZcmED6KVIHisdjxntLDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peO0C-00Afy2-1A; Mon, 20 Mar 2023 22:29:16 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peO0B-00Afxb-15 for linux-arm-kernel@bombadil.infradead.org; Mon, 20 Mar 2023 22:29:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=qrygnSNSRoB98z7eeIniYEZp4NCAJ7SoMHacTnTpeA4=; b=rqjwcOyj1wpnvt8U4Zf/LjcFPv ZzJZ9we0acC3kvBZntIq5/jMn+EkIANRKqkk+Jm5sdsJnEEmk6vIhbDFViIvcEEXCJYwqWkaCB21O WY9DVpFnkXZK792OEBistrzdThWIEOdPFVTDeBld6V859bO5FJ8Lz0ZpPEV6j5gGx/LKQLUgDGS31 NfF2Uywcu0wYtkkLFc6xKQGpi/mYMp2N9TvXVf4XMUELDqbgxamgpjB7nZN8UDc/eyuyUVGTQA4go wVEXUl1CsShzSsW8xXFnWE0FdpIR6bMNHuPstmqB3kdI/etrXXFRWCSSUJd5+NdcNnX8IXvb4UyG4 IO9yZVhQ==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1peO09-001SAz-8X; Mon, 20 Mar 2023 22:29:13 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EC8E04052D; Mon, 20 Mar 2023 19:29:09 -0300 (-03) Date: Mon, 20 Mar 2023 19:29:09 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: James Clark , linux-perf-users@vger.kernel.org, Anshuman.Khandual@arm.com, Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , John Garry , Will Deacon , Mike Leach , Leo Yan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/4] Enable display of partial and empty SVE predicates from Arm SPE data Message-ID: References: <20230320151509.1137462-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gTW9uLCBNYXIgMjAsIDIwMjMgYXQgMTA6NTA6NTlBTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBPbiBNb24sIE1hciAyMCwgMjAyMyBhdCA4OjE14oCvQU0gSmFtZXMgQ2xhcmsgPGph bWVzLmNsYXJrQGFybS5jb20+IHdyb3RlOgo+ID4KPiA+IENoYW5nZXMgc2luY2UgdjE6Cj4gPiAg KiBSZWJhc2Ugb250byBwZXJmL2NvcmUgYmVjYXVzZSBpdCBubyBsb25nZXIgYXBwbGllZCBjbGVh bmx5Cj4gPgo+ID4gLS0tLS0tLS0tLS0tCj4gPgo+ID4gSGksCj4gPgo+ID4gSSdtIHN1Ym1pdHRp bmcgdGhpcyBvbiBiZWhhbGYgb2YgR2VybWFuIHdobyBtb3ZlZCBvbiB0byB3b3JrIG9uIG90aGVy Cj4gPiB0aGluZ3MgaW4gQXJtIGJlZm9yZSBoZSBjb3VsZCBmaW5pc2ggaXQgb2ZmLgo+ID4KPiA+ IFRoZSBwcmVkaWNhdGUgaW5mb3JtYXRpb24gaXMgYXZhaWxhYmxlIG9uIFNQRSBzYW1wbGVzIGZy b20KPiA+IEFybXY4LjMgKEZFQVRfU1BFdjFwMSksIHRoaXMgY291bGQgYmUgdXNlZnVsIGluZm8g Zm9yIHByb2ZpbGluZyBTVkUKPiA+IGNvZGUgYXMgcGFydGlhbCBhbmQgZW1wdHkgcHJlZGljYXRl cyBpbmRpY2F0ZSB0aGF0IHRoZSBmdWxsIHZlY3Rvcgo+ID4gd2lkdGggaXNuJ3QgYmVpbmcgdXNl ZC4gVGhlcmUgaXMgYSBnb29kIGV4YW1wbGUgaW4gdGhlIGxhc3QgY29tbWl0Cj4gPiBtZXNzYWdl Lgo+ID4KPiA+IFRob3VnaCBjdXJyZW50bHksIHRoZXJlIGlzbid0IGEgc3VpdGFibGUgZmllbGQg dG8gc3RvcmUgdGhlIGluZm8KPiA+IG9uIFBlcmYgc2FtcGxlcywgc28gdGhpcyBjaGFuZ2UgYWxz byBhZGRzIGEgbmV3IFNJTUQgZmllbGQuCj4gPiBUaGlzIGZpZWxkIGNvdWxkIGJlIHVzZWQgYnkg b3RoZXIgYXJjaGl0ZWN0dXJlcywgYnV0IGN1cnJlbnRseSB0aGVyZQo+ID4gaXMgb25seSBvbmUg Yml0IHJlc2VydmVkIHRvIGlkZW50aWZ5IFNWRS4gSXQncyBvbmx5IGFkZGVkIHRvCj4gPiBzdHJ1 Y3QgcGVyZl9zYW1wbGUgb24gdGhlIHVzZXJzcGFjZSBzaWRlLCBhbmQgaXNuJ3QgcGFydCBvZiB0 aGUga2VybmVsCj4gPiBBQkksIHNvIGl0IGRvZXNuJ3Qgc3Vydml2ZSBhIHBlcmYgaW5qZWN0LiBB bHRob3VnaCB0aGlzIGlzIHRoZQo+ID4gc2FtZSBiZWhhdmlvciBmb3Igc29tZSBvdGhlciBmaWVs ZHMgbGlrZSBicmFuY2ggZmxhZ3MsIHNvIEkgZG9uJ3QKPiA+IHRoaW5rIGl0IHNob3VsZCBiZSBh biBpc3N1ZSB0byBkbyBzb21ldGhpbmcgc2ltaWxhciBoZXJlLiBQZXJoYXBzIGluCj4gPiB0aGUg ZnV0dXJlIHdlIGNvdWxkIG1ha2Ugc3VyZSBldmVyeXRoaW5nIHRoYXQgaXMgc3ludGhlc2lzZWQg ZnJvbQo+ID4gYXV4dHJhY2UgZGF0YSBhbHNvIG1ha2VzIGl0IGJhY2sgaW50byB0aGUgbmV3IFBl cmYgaW5qZWN0IGZpbGUgd2l0aG91dAo+ID4gYmVpbmcgbG9zdC4KPiAKPiBTZXJpZXM6Cj4gQWNr ZWQtYnk6IElhbiBSb2dlcnMgPGlyb2dlcnNAZ29vZ2xlLmNvbT4KClRoYW5rcywgYXBwbGllZC4K Ci0gQXJuYWxkbwoKIAo+IFRoYW5rcywKPiBJYW4KPiAKPiA+IEdlcm1hbiBHb21leiAoNCk6Cj4g PiAgIHBlcmYgZXZlbnQ6IEFkZCBzaW1kX2ZsYWdzIGZpZWxkIHRvIHBlcmZfc2FtcGxlCj4gPiAg IHBlcmYgYXJtLXNwZTogUmVmYWN0b3IgYXJtLXNwZSB0byBzdXBwb3J0IG9wZXJhdGlvbiBwYWNr ZXQgdHlwZQo+ID4gICBwZXJmIGFybS1zcGU6IEFkZCBTVkUgZmxhZ3MgdG8gdGhlIFNQRSBzYW1w bGVzCj4gPiAgIHBlcmYgcmVwb3J0OiBBZGQgJ3NpbWQnIHNvcnQgZmllbGQKPiA+Cj4gPiAgdG9v bHMvcGVyZi9Eb2N1bWVudGF0aW9uL3BlcmYtcmVwb3J0LnR4dCAgICAgIHwgIDEgKwo+ID4gIC4u Li91dGlsL2FybS1zcGUtZGVjb2Rlci9hcm0tc3BlLWRlY29kZXIuYyAgICB8IDMwICsrKysrKysr KystLQo+ID4gIC4uLi91dGlsL2FybS1zcGUtZGVjb2Rlci9hcm0tc3BlLWRlY29kZXIuaCAgICB8 IDQ3ICsrKysrKysrKysrKysrKy0tLS0KPiA+ICB0b29scy9wZXJmL3V0aWwvYXJtLXNwZS5jICAg ICAgICAgICAgICAgICAgICAgfCAyOCArKysrKysrKystLQo+ID4gIHRvb2xzL3BlcmYvdXRpbC9o aXN0LmMgICAgICAgICAgICAgICAgICAgICAgICB8ICAxICsKPiA+ICB0b29scy9wZXJmL3V0aWwv aGlzdC5oICAgICAgICAgICAgICAgICAgICAgICAgfCAgMSArCj4gPiAgdG9vbHMvcGVyZi91dGls L3NhbXBsZS5oICAgICAgICAgICAgICAgICAgICAgIHwgMTMgKysrKysKPiA+ICB0b29scy9wZXJm L3V0aWwvc29ydC5jICAgICAgICAgICAgICAgICAgICAgICAgfCA0NyArKysrKysrKysrKysrKysr KysrCj4gPiAgdG9vbHMvcGVyZi91dGlsL3NvcnQuaCAgICAgICAgICAgICAgICAgICAgICAgIHwg IDIgKwo+ID4gIDkgZmlsZXMgY2hhbmdlZCwgMTUyIGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9u cygtKQo+ID4KPiA+Cj4gPiBiYXNlLWNvbW1pdDogOTZkNTQxNjk5ZTVjNTBiMWJjMmQ1MGM4M2Nk NzE0NTk5NGQ1ZjA3MQo+ID4gLS0KPiA+IDIuMzQuMQo+ID4KCi0tIAoKLSBBcm5hbGRvCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==