From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-usb@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] usb: host: u132-hcd: Delete driver
Date: Tue, 21 Mar 2023 11:47:13 +0100 [thread overview]
Message-ID: <ZBmLMXBuO8bdwos9@kroah.com> (raw)
In-Reply-To: <20230321103638.343886-1-u.kleine-koenig@pengutronix.de>
On Tue, Mar 21, 2023 at 11:36:38AM +0100, Uwe Kleine-König wrote:
> This driver got its last actual change in 2006 and is probably unused as
> nowbody should use a cardbus to USB adapter any more.
>
> If it were still used, the driver was in urgent need for maintainer
> love. (Explicit kref handling, underdocumented locking, .remove() can
> return errors ...)
>
> Also the link in the (now removed) help text doesn't look actively
> maintained. According to archive.org it forwarded to
> http://www.copenhagen-hotel.net/ already back in 2018.
>
> So don't waste more time on this driver and just delete it.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/mips/configs/mtx1_defconfig | 1 -
> arch/powerpc/configs/ppc6xx_defconfig | 1 -
> drivers/usb/Makefile | 1 -
> drivers/usb/host/Kconfig | 27 -
> drivers/usb/host/Makefile | 1 -
> drivers/usb/host/u132-hcd.c | 3239 -------------------------
> drivers/usb/misc/Kconfig | 2 -
> 7 files changed, 3272 deletions(-)
> delete mode 100644 drivers/usb/host/u132-hcd.c
>
> diff --git a/arch/mips/configs/mtx1_defconfig b/arch/mips/configs/mtx1_defconfig
> index 89a1511d2ee4..7b6a2a9daa10 100644
> --- a/arch/mips/configs/mtx1_defconfig
> +++ b/arch/mips/configs/mtx1_defconfig
> @@ -497,7 +497,6 @@ CONFIG_USB_EHCI_ROOT_HUB_TT=y
> CONFIG_USB_OHCI_HCD=m
> CONFIG_USB_OHCI_HCD_PLATFORM=m
> CONFIG_USB_UHCI_HCD=m
> -CONFIG_USB_U132_HCD=m
> CONFIG_USB_SL811_HCD=m
> CONFIG_USB_SL811_CS=m
> CONFIG_USB_ACM=m
> diff --git a/arch/powerpc/configs/ppc6xx_defconfig b/arch/powerpc/configs/ppc6xx_defconfig
> index 110258277959..fd5cc93c4a99 100644
> --- a/arch/powerpc/configs/ppc6xx_defconfig
> +++ b/arch/powerpc/configs/ppc6xx_defconfig
> @@ -845,7 +845,6 @@ CONFIG_USB_OHCI_HCD=m
> CONFIG_USB_OHCI_HCD_PPC_OF_BE=y
> CONFIG_USB_OHCI_HCD_PPC_OF_LE=y
> CONFIG_USB_UHCI_HCD=m
> -CONFIG_USB_U132_HCD=m
> CONFIG_USB_SL811_HCD=m
> CONFIG_USB_ACM=m
> CONFIG_USB_PRINTER=m
> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
> index a81e6ef293af..3a9a0dd4be70 100644
> --- a/drivers/usb/Makefile
> +++ b/drivers/usb/Makefile
> @@ -31,7 +31,6 @@ obj-$(CONFIG_USB_FHCI_HCD) += host/
> obj-$(CONFIG_USB_XHCI_HCD) += host/
> obj-$(CONFIG_USB_SL811_HCD) += host/
> obj-$(CONFIG_USB_ISP1362_HCD) += host/
> -obj-$(CONFIG_USB_U132_HCD) += host/
> obj-$(CONFIG_USB_R8A66597_HCD) += host/
> obj-$(CONFIG_USB_FSL_USB2) += host/
> obj-$(CONFIG_USB_FOTG210_HCD) += host/
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index eacb603ad1b2..c170672f847e 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -622,33 +622,6 @@ config FHCI_DEBUG
> Say "y" to see some FHCI debug information and statistics
> through debugfs.
>
> -config USB_U132_HCD
> - tristate "Elan U132 Adapter Host Controller"
> - depends on USB_FTDI_ELAN
I think you can also delete this driver (drivers/usb/misc/ftdi-elan.c)
as well as it is the same expired domain and came in at the same time.
thanks,
greg k-h
prev parent reply other threads:[~2023-03-21 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 10:36 [PATCH] usb: host: u132-hcd: Delete driver Uwe Kleine-König
2023-03-21 10:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBmLMXBuO8bdwos9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.