From: Vincent Donnefort <vdonnefort@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH 1/2] ring-buffer: Introducing ring-buffer mapping functions
Date: Tue, 21 Mar 2023 16:50:49 +0000 [thread overview]
Message-ID: <ZBngaarixYOgBCOA@google.com> (raw)
In-Reply-To: <20230321124425.6ca93621@gandalf.local.home>
On Tue, Mar 21, 2023 at 12:44:25PM -0400, Steven Rostedt wrote:
> On Tue, 21 Mar 2023 11:40:47 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > >
> > > Thanks a lot for having a look. Do you mind if I fold this in my patch for a V2?
> >
> > Hold off, I found some bugs that I'm fixing ;-)
>
> OK, you can fold this in. I also fixed an issue with your patch where it
> was missing setting a page->mapping and also clearing it.
>
> I haven't updated to replace "__u32 *data_pages[]" with an "__u32 data_start"
> But I think that should still be done.
>
> -- Steve
>
[...]
Thanks! I'll prepare a v2 with all that!
next prev parent reply other threads:[~2023-03-21 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 14:33 [PATCH 0/2] Introducing trace buffer mapping by user-space Vincent Donnefort
2023-03-17 14:33 ` [PATCH 1/2] ring-buffer: Introducing ring-buffer mapping functions Vincent Donnefort
2023-03-21 1:45 ` Steven Rostedt
2023-03-21 15:17 ` Vincent Donnefort
2023-03-21 15:40 ` Steven Rostedt
2023-03-21 16:20 ` Vincent Donnefort
2023-03-21 16:51 ` Steven Rostedt
2023-03-21 16:44 ` Steven Rostedt
2023-03-21 16:50 ` Vincent Donnefort [this message]
2023-03-17 14:33 ` [PATCH 2/2] tracing: Allow user-space mapping of the ring-buffer Vincent Donnefort
-- strict thread matches above, loose matches on Subject: below --
2023-03-18 3:00 [PATCH 1/2] ring-buffer: Introducing ring-buffer mapping functions kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBngaarixYOgBCOA@google.com \
--to=vdonnefort@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.