From: Peter Xu <peterx@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Nadav Amit <nadav.amit@gmail.com>,
David Hildenbrand <david@redhat.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
linux-stable <stable@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: Fix uffd wr-protection for CoW optimization path
Date: Tue, 21 Mar 2023 17:41:54 -0400 [thread overview]
Message-ID: <ZBokogPMNsz+1Rsb@x1n> (raw)
In-Reply-To: <20230321205719.GA6030@monkey>
On Tue, Mar 21, 2023 at 01:57:19PM -0700, Mike Kravetz wrote:
> > This patch fixes an issue that a hugetlb uffd-wr-protected mapping can be
> > writable even with uffd-wp bit set. It only happens with all these
> > conditions met: (1) hugetlb memory (2) private mapping (3) original mapping
> > was missing, then (4) being wr-protected (IOW, pte marker installed). Then
> ^^^^
> Nit, but is the word "then" intended to be there? Almost makes it sound as
> if wr-protected was a result of the previous 3 conditions being met.
Not intended.. Since this is not fixup-able, I'll reword here when I'll
need to repost.
[...]
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Thanks!
--
Peter Xu
prev parent reply other threads:[~2023-03-21 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:18 [PATCH] mm/hugetlb: Fix uffd wr-protection for CoW optimization path Peter Xu
2023-03-21 19:35 ` Peter Xu
2023-03-21 19:36 ` David Hildenbrand
2023-03-21 19:50 ` Peter Xu
2023-03-23 15:33 ` Muhammad Usama Anjum
2023-03-23 22:11 ` Peter Xu
2023-03-24 6:32 ` Muhammad Usama Anjum
2023-03-24 8:51 ` David Hildenbrand
2023-03-24 14:11 ` Peter Xu
2023-03-21 20:57 ` Mike Kravetz
2023-03-21 21:41 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBokogPMNsz+1Rsb@x1n \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nadav.amit@gmail.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.