From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
"David Hildenbrand" <david@redhat.com>,
"Borntraeger, Christian" <borntraeger@de.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
fiuczy@linux.ibm.com, "Halil Pasic" <pasic@linux.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options
Date: Wed, 22 Mar 2023 09:28:52 +0000 [thread overview]
Message-ID: <ZBrKVGVHRtqyaKvL@redhat.com> (raw)
In-Reply-To: <CABgObfaN3sLipc2UuoZc2yHP0YK3e59sK5wn8gpkJ8xgNHc7qg@mail.gmail.com>
On Tue, Mar 21, 2023 at 09:47:57PM +0100, Paolo Bonzini wrote:
> Il lun 20 mar 2023, 16:42 Thomas Huth <thuth@redhat.com> ha scritto:
>
> > Would it make sense to add it e.g. to "-action" instead, i.e. something
> > like
> > "-action teardown=async" ?
> >
>
> -action is just a wrapper for the action-set QMP command. I don't think it
> fits very well; its arguments are only guest actions while asynchronous
> tear down happens for example when you issue a quit command on the monitor.
Right, we discussed -action when this feature was first proposed and
that was the reason it was discounted.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-03-22 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:16 [PATCH v2 0/1] util/async-teardown: wire up query-command-line-options Claudio Imbrenda
2023-03-20 13:16 ` [PATCH v2 1/1] " Claudio Imbrenda
2023-03-20 15:31 ` Markus Armbruster
2023-03-20 15:42 ` Thomas Huth
2023-03-20 16:05 ` Markus Armbruster
2023-03-20 16:21 ` Claudio Imbrenda
2023-03-21 20:47 ` Paolo Bonzini
2023-03-22 9:28 ` Daniel P. Berrangé [this message]
2023-03-22 14:00 ` Thomas Huth
2023-03-22 14:48 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBrKVGVHRtqyaKvL@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.