From: Simon Horman <simon.horman@corigine.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing the ranges
Date: Wed, 22 Mar 2023 17:53:37 +0100 [thread overview]
Message-ID: <ZBsykS8b+antCVL1@corigine.com> (raw)
In-Reply-To: <20230322165126.23bwb4rnnbuuwlnx@skbuf>
On Wed, Mar 22, 2023 at 06:51:26PM +0200, Vladimir Oltean wrote:
> On Wed, Mar 22, 2023 at 05:46:53PM +0100, Simon Horman wrote:
> > This feels a bit more like an enhancement than a fix to me,
> > but I don't feel strongly about it.
>
> How so?
>
> Since commit 38b922c91227 ("net: enetc: expose some standardized ethtool
> counters") - merged in kernel v6.1 - the user could run this command and
> see this output:
>
> $ ethtool -S eno0 --groups rmon
> Standard stats for eno0:
> rmon-etherStatsUndersizePkts: 0
> rmon-etherStatsOversizePkts: 0
> rmon-etherStatsFragments: 0
> rmon-etherStatsJabbers: 0
> rx-rmon-etherStatsPkts64to64Octets: 0
> rx-rmon-etherStatsPkts65to127Octets: 0
> rx-rmon-etherStatsPkts128to255Octets: 0
> rx-rmon-etherStatsPkts256to511Octets: 0
> rx-rmon-etherStatsPkts512to1023Octets: 0
> rx-rmon-etherStatsPkts1024to1522Octets: 0
> rx-rmon-etherStatsPkts1523to9600Octets: 0
> tx-rmon-etherStatsPkts64to64Octets: 0
> tx-rmon-etherStatsPkts65to127Octets: 0
> tx-rmon-etherStatsPkts128to255Octets: 0
> tx-rmon-etherStatsPkts256to511Octets: 0
> tx-rmon-etherStatsPkts512to1023Octets: 0
> tx-rmon-etherStatsPkts1024to1522Octets: 0
> tx-rmon-etherStatsPkts1523to9600Octets: 0
>
> After the blamed commit - merged in the v6.3 release candidates - the
> same command produces the following output:
>
> $ ethtool -S eno0 --groups rmon
> Standard stats for eno0:
> rmon-etherStatsUndersizePkts: 0
> rmon-etherStatsOversizePkts: 0
> rmon-etherStatsFragments: 0
> rmon-etherStatsJabbers: 0
>
> So why is this an enhancement?
My understanding was incorrect.
I now agree it is a fix.
next prev parent reply other threads:[~2023-03-22 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 23:28 [PATCH net] net: enetc: fix aggregate RMON counters not showing the ranges Vladimir Oltean
2023-03-22 16:46 ` Simon Horman
2023-03-22 16:51 ` Vladimir Oltean
2023-03-22 16:53 ` Simon Horman [this message]
2023-03-23 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBsykS8b+antCVL1@corigine.com \
--to=simon.horman@corigine.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.