From: Simon Horman <simon.horman@corigine.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ethernet: mediatek: mtk_ppe: prefer newly added l2 flows over existing ones
Date: Wed, 22 Mar 2023 21:00:52 +0100 [thread overview]
Message-ID: <ZBtedOG4W28dKAR9@corigine.com> (raw)
In-Reply-To: <c6c52acc-0203-f4e5-a368-850d9f459b08@nbd.name>
On Wed, Mar 22, 2023 at 04:09:25PM +0100, Felix Fietkau wrote:
> On 22.03.23 15:00, Simon Horman wrote:
> > On Tue, Mar 21, 2023 at 02:36:09PM +0100, Felix Fietkau wrote:
> > > When a device is roaming between interfaces and a new flow entry is created,
> > > we should assume that its output device is more up to date than whatever
> > > entry existed already.
> >
> > As per patch 1/2. checkpatch complains that the patch description
> > has lines more than 75 characters long.
> Will do.
>
> > That aside, this change looks good to me.
> > But I'm wondering if it is fixing a bug.
> > Or just improving something suboptimal (form a user experience POV).
> In my opinion, this is just an improvement, not a bugfix.
Sure, thanks for the clarification.
next prev parent reply other threads:[~2023-03-22 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:36 [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add code for offloading flows from wlan devices Felix Fietkau
2023-03-21 13:36 ` [PATCH net-next 2/2] net: ethernet: mediatek: mtk_ppe: prefer newly added l2 flows over existing ones Felix Fietkau
2023-03-22 14:00 ` Simon Horman
2023-03-22 15:09 ` Felix Fietkau
2023-03-22 20:00 ` Simon Horman [this message]
2023-03-22 14:04 ` [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add code for offloading flows from wlan devices Simon Horman
2023-03-22 14:29 ` Simon Horman
2023-03-22 15:19 ` Felix Fietkau
2023-03-22 20:05 ` Simon Horman
2023-03-22 15:18 ` Felix Fietkau
2023-03-22 20:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBtedOG4W28dKAR9@corigine.com \
--to=simon.horman@corigine.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.