From: Deepak R Varma <drv@mailo.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Khadija Kamran <kamrankhadijadj@gmail.com>,
outreachy@lists.linux.dev,
Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Christian Gromm <christian.gromm@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH v2] staging: most: fix line ending with '('
Date: Thu, 23 Mar 2023 09:44:59 +0530 [thread overview]
Message-ID: <ZBvSQxgiFffWsoef@ubun2204.myguest.virtualbox.org> (raw)
In-Reply-To: <061a2fea-b3da-551d-f6d2-0da30b0ac879@infradead.org>
On Wed, Mar 22, 2023 at 08:12:23AM -0700, Randy Dunlap wrote:
> Hi--
>
> And FTR, I still haven't found anything in coding-style.rst that says that
> lines should not end with an open parenthesis. Did I overlook it?
Hi Randy,
You are correct. I did not find anything clear or obvious that calls out not
ending the lines with a '(' symbol.
I think the other guideline from the coding style is to align the overrunning
argument list in the next lines such that they match the arg1 after '('. So, I
think that may be the reason why checkpatch is coded to catch such lines.
Regards,
Deepak.
>
> Thanks.
prev parent reply other threads:[~2023-03-23 4:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 15:01 [PATCH v2] staging: most: fix line ending with '(' Khadija Kamran
2023-03-22 15:09 ` Dan Carpenter
2023-03-22 18:06 ` Khadija Kamran
2023-03-23 4:48 ` Dan Carpenter
2023-03-23 12:06 ` Khadija Kamran
2023-03-22 15:12 ` Randy Dunlap
2023-03-23 4:14 ` Deepak R Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBvSQxgiFffWsoef@ubun2204.myguest.virtualbox.org \
--to=drv@mailo.com \
--cc=apw@canonical.com \
--cc=christian.gromm@microchip.com \
--cc=dwaipayanray1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukas.bulwahn@gmail.com \
--cc=outreachy@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.