From: Christoph Hellwig <hch@infradead.org>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: senozhatsky@chromium.org, viro@zeniv.linux.org.uk,
axboe@kernel.dk, willy@infradead.org, brauner@kernel.org,
akpm@linux-foundation.org, minchan@kernel.org,
hubcap@omnibond.com, martin@omnibond.com, mcgrof@kernel.org,
devel@lists.orangefs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, gost.dev@samsung.com
Subject: Re: [RFC v2 1/5] zram: remove zram_page_end_io function
Date: Thu, 23 Mar 2023 03:35:41 -0700 [thread overview]
Message-ID: <ZBwrfT8TA5GC5+RH@infradead.org> (raw)
In-Reply-To: <20230322135013.197076-2-p.raghav@samsung.com>
On Wed, Mar 22, 2023 at 02:50:09PM +0100, Pankaj Raghav wrote:
> - if (!parent)
> - bio->bi_end_io = zram_page_end_io;
> - else
> + if (parent)
I don't think a non-chained bio without and end_io handler can work.
This !parent case seems to come from writeback_store, and as far as
I can tell is broken already in the current code as it just fires
off an async read without ever waiting for it, using an on-stack bio
just to make things complicated.
The bvec reading code in zram is a mess, but I have an idea how
to clean it up with a little series that should also help with
this issue.
next prev parent reply other threads:[~2023-03-23 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230322135015eucas1p2ff980e76159f0ceef7bf66934580bd6c@eucas1p2.samsung.com>
2023-03-22 13:50 ` [RFC v2 0/5] remove page_endio() Pankaj Raghav
2023-03-22 13:50 ` [RFC v2 1/5] zram: remove zram_page_end_io function Pankaj Raghav
2023-03-23 10:35 ` Christoph Hellwig [this message]
2023-03-23 15:50 ` Pankaj Raghav
2023-03-22 13:50 ` [RFC v2 2/5] orangefs: use folios in orangefs_readahead Pankaj Raghav
2023-03-22 13:50 ` [RFC v2 3/5] mpage: split bi_end_io callback for reads and writes Pankaj Raghav
2023-03-22 13:50 ` [RFC v2 4/5] mpage: use folios in bio end_io handler Pankaj Raghav
2023-03-22 14:19 ` Matthew Wilcox
2023-03-22 13:50 ` [RFC v2 5/5] filemap: remove page_endio() Pankaj Raghav
2023-03-22 19:09 ` [RFC v2 0/5] " Matthew Wilcox
2023-03-23 15:00 ` Pankaj Raghav
2023-03-23 15:33 ` Matthew Wilcox
2023-03-23 16:16 ` Pankaj Raghav
2023-03-23 14:30 ` Mike Marshall
2023-03-23 16:22 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBwrfT8TA5GC5+RH@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=gost.dev@samsung.com \
--cc=hubcap@omnibond.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.