From: Simon Horman <simon.horman@corigine.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@gmail.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next] ipv6: prevent router_solicitations for team port
Date: Thu, 23 Mar 2023 15:41:39 +0100 [thread overview]
Message-ID: <ZBxlI7LSDKgxAw3Q@corigine.com> (raw)
In-Reply-To: <7c052c3bdf8c1ac48833ace66725adf1f9794711.1679528141.git.lucien.xin@gmail.com>
On Wed, Mar 22, 2023 at 07:35:41PM -0400, Xin Long wrote:
> The issue fixed for bonding in commit c2edacf80e15 ("bonding / ipv6: no
> addrconf for slaves separately from master") also exists in team driver.
> However, we can't just disable ipv6 addrconf for team ports, as 'teamd'
> will need it when nsns_ping watch is used in the user space.
>
> Instead of preventing ipv6 addrconf, this patch only prevents RS packets
> for team ports, as it did in commit b52e1cce31ca ("ipv6: Don't send rs
> packets to the interface of ARPHRD_TUNNEL").
>
> Note that we do not prevent DAD packets, to avoid the changes getting
> intricate / hacky. Also, usually sysctl dad_transmits is set to 1 and
> only 1 DAD packet will be sent, and by now no libteam user complains
> about DAD packets on team ports, unlike RS packets.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-23 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 23:35 [PATCH net-next] ipv6: prevent router_solicitations for team port Xin Long
2023-03-23 14:41 ` Simon Horman [this message]
2023-03-24 9:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBxlI7LSDKgxAw3Q@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.