From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yohan Joung <jyh429@gmail.com>
Cc: lkp@intel.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
oe-kbuild-all@lists.linux.dev
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix align check for npo2
Date: Thu, 23 Mar 2023 16:47:51 -0700 [thread overview]
Message-ID: <ZBzlJ36kO5KvxODB@google.com> (raw)
In-Reply-To: <20230323072338.175-1-jyh429@gmail.com>
On 03/23, Yohan Joung wrote:
> Fix alignment check to be correct in npo2 as well
>
> Signed-off-by: Yohan Joung <yohan.joung@sk.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 055e70e77aa2..46458085a8d0 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1858,7 +1858,7 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi,
> sector = SECTOR_FROM_BLOCK(blkstart);
> nr_sects = SECTOR_FROM_BLOCK(blklen);
>
> - if (sector & (bdev_zone_sectors(bdev) - 1) ||
> + if (sector % bdev_zone_sectors(bdev) ||
Need to use div_u64_rem()?
> nr_sects != bdev_zone_sectors(bdev)) {
> f2fs_err(sbi, "(%d) %s: Unaligned zone reset attempted (block %x + %x)",
> devi, sbi->s_ndevs ? FDEV(devi).path : "",
>
> base-commit: d15180a8d1d72c7bddcb700d2c9ffdab7d2b9481
> --
> 2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yohan Joung <jyh429@gmail.com>
Cc: lkp@intel.com, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
Yohan Joung <yohan.joung@sk.com>
Subject: Re: [PATCH] f2fs: fix align check for npo2
Date: Thu, 23 Mar 2023 16:47:51 -0700 [thread overview]
Message-ID: <ZBzlJ36kO5KvxODB@google.com> (raw)
In-Reply-To: <20230323072338.175-1-jyh429@gmail.com>
On 03/23, Yohan Joung wrote:
> Fix alignment check to be correct in npo2 as well
>
> Signed-off-by: Yohan Joung <yohan.joung@sk.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 055e70e77aa2..46458085a8d0 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1858,7 +1858,7 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi,
> sector = SECTOR_FROM_BLOCK(blkstart);
> nr_sects = SECTOR_FROM_BLOCK(blklen);
>
> - if (sector & (bdev_zone_sectors(bdev) - 1) ||
> + if (sector % bdev_zone_sectors(bdev) ||
Need to use div_u64_rem()?
> nr_sects != bdev_zone_sectors(bdev)) {
> f2fs_err(sbi, "(%d) %s: Unaligned zone reset attempted (block %x + %x)",
> devi, sbi->s_ndevs ? FDEV(devi).path : "",
>
> base-commit: d15180a8d1d72c7bddcb700d2c9ffdab7d2b9481
> --
> 2.25.1
next prev parent reply other threads:[~2023-03-23 23:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 13:14 [f2fs-dev] [PATCH] f2fs: fix align check for npo2 Yohan Joung
2023-03-22 13:14 ` Yohan Joung
2023-03-23 2:37 ` [f2fs-dev] " kernel test robot
2023-03-23 2:37 ` kernel test robot
2023-03-23 7:23 ` [f2fs-dev] " Yohan Joung
2023-03-23 7:23 ` Yohan Joung
2023-03-23 23:47 ` Jaegeuk Kim [this message]
2023-03-23 23:47 ` Jaegeuk Kim
2023-03-24 13:07 ` [f2fs-dev] " Yohan Joung
2023-03-24 13:07 ` Yohan Joung
2023-04-01 1:49 ` [f2fs-dev] " Chao Yu
2023-04-01 1:49 ` Chao Yu
2023-04-02 3:17 ` Yohan Joung
2023-04-02 3:17 ` Yohan Joung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBzlJ36kO5KvxODB@google.com \
--to=jaegeuk@kernel.org \
--cc=jyh429@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.