All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Somlo <gsomlo@gmail.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v1] docs: Correct FW_JUMP_FDT_ADDR calculation example
Date: Thu, 23 Mar 2023 20:39:27 -0400	[thread overview]
Message-ID: <ZBzxPznRky+TFreC@Entropy.lan> (raw)
In-Reply-To: <20230323171800.fngjibzpt4omg3ml@orel>

On Thu, Mar 23, 2023 at 06:18:00PM +0100, Andrew Jones wrote:
> On Wed, Mar 22, 2023 at 01:04:48PM -0400, Gabriel Somlo wrote:
> > When using `PLATFORM=generic` defaults, the kernel is loaded at
> > `FW_JUMP_ADDR = FW_TEXT_START + 0x200000`, and the FDT is loaded at
> > `FW_JUMP_FDT_ADDR = FW_TEXT_START + 0x2200000`.
> > 
> > Therefore, the maximum kernel size before `FW_JUMP_FDT_ADDR` must
> > be increased is the difference, or `0x2000000`.
> 
> Sounds good, but this is only correct for RV64. For RV32 it should be
> 0x1e00000. I wonder if we should do something like
> 
>    ```
>    ${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n '/^ +[0-9]+ /\
>    {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' \
> -  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
> -  increase FW_JUMP_FDT_ADDR
> +  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && echo fdt overlaps \
> +  kernel, increase FW_JUMP_FDT_ADDR
> 
>    ${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | \
>    awk -n '/^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}'\
> -  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
> -  increase FW_JUMP_FDT_ADDR
> +  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && echo fdt overlaps \
> +  kernel, increase FW_JUMP_FDT_ADDR
>    ```
> 
> instead?

Yeah, v2 (with a commit blurb updated to match) should be on its way.

Thanks,
--Gabriel


      reply	other threads:[~2023-03-24  0:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 17:04 [PATCH v1] docs: Correct FW_JUMP_FDT_ADDR calculation example Gabriel Somlo
2023-03-23 17:18 ` Andrew Jones
2023-03-24  0:39   ` Gabriel Somlo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBzxPznRky+TFreC@Entropy.lan \
    --to=gsomlo@gmail.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.