From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2 0/3] lib/string_helpers et al.: Change return value of strreplace()
Date: Wed, 5 Apr 2023 16:34:31 +0300 [thread overview]
Message-ID: <ZC1454AwRUNFTbIW@smile.fi.intel.com> (raw)
In-Reply-To: <20230323123704.37983-1-andriy.shevchenko@linux.intel.com>
On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote:
> It's more convenient to have strreplace() to return the pointer to
> the string itself. This will help users to make their code better.
>
> The patch 1 kills the only user of the returned value of strreplace(),
> Patch 2 converts the return value of strreplace(). And patch 3 shows
> how it may be useful. That said, the series can be routed via fs tree,
> with or without the last patch.
Since there are no comments, who can apply this (patches 1 and 2)?
Greg, are you fine with the kobject change?
> In v2:
> - removed not anymore used variable (LKP)
> - added tag (Jan)
> - fixed wording (Kees)
> - actually return the pointer to the string itself
>
> Andy Shevchenko (3):
> jbd2: Avoid printing outside the boundary of the buffer
> lib/string_helpers: Change returned value of the strreplace()
> kobject: Use return value of strreplace()
>
> fs/jbd2/journal.c | 6 ++----
> include/linux/string.h | 2 +-
> lib/kobject.c | 3 +--
> lib/string_helpers.c | 12 ++++++++----
> 4 files changed, 12 insertions(+), 11 deletions(-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-05 13:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:37 [PATCH v2 0/3] lib/string_helpers et al.: Change return value of strreplace() Andy Shevchenko
2023-03-23 12:37 ` [PATCH v2 1/3] jbd2: Avoid printing outside the boundary of the buffer Andy Shevchenko
2023-03-23 12:37 ` [PATCH v2 2/3] lib/string_helpers: Change returned value of the strreplace() Andy Shevchenko
2023-03-23 12:37 ` [PATCH v2 3/3] kobject: Use return value of strreplace() Andy Shevchenko
2023-03-26 13:37 ` David Laight
2023-04-05 13:34 ` Andy Shevchenko [this message]
2023-04-05 14:24 ` [PATCH v2 0/3] lib/string_helpers et al.: Change " Greg Kroah-Hartman
2023-04-05 14:38 ` Andy Shevchenko
2023-04-06 2:58 ` Kees Cook
2023-06-05 14:04 ` Andy Shevchenko
2023-06-05 16:57 ` Greg Kroah-Hartman
2023-06-05 17:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC1454AwRUNFTbIW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=cezary.rojewski@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.com \
--cc=keescook@chromium.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.