Re: [PATCH 2/5] efi: selftest: Make load_file() and load_file2() static

[Ilias Apalodimas <ilias.apalodimas@linaro.org>]

On Wed, Apr 05, 2023 at 08:15:16PM +0800, Bin Meng wrote:
> load_file() and load_file2() are only referenced in
> efi_selftest_load_file.c
> 
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
> 
>  lib/efi_selftest/efi_selftest_load_file.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/lib/efi_selftest/efi_selftest_load_file.c b/lib/efi_selftest/efi_selftest_load_file.c
> index 8784a76172..14df761172 100644
> --- a/lib/efi_selftest/efi_selftest_load_file.c
> +++ b/lib/efi_selftest/efi_selftest_load_file.c
> @@ -206,11 +206,11 @@ static efi_status_t decompress(u8 **image)
>   * @buffer_size:	(required) buffer size
>   * @buffer:		buffer to which the file is to be loaded
>   */
> -efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this,
> -			      struct efi_device_path *file_path,
> -			      bool boot_policy,
> -			      efi_uintn_t *buffer_size,
> -			      void *buffer)
> +static efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this,
> +				     struct efi_device_path *file_path,
> +				     bool boot_policy,
> +				     efi_uintn_t *buffer_size,
> +				     void *buffer)
>  {
>  	++load_file_call_count;
>  	if (memcmp(file_path, dp_lf_file_remainder,
> @@ -243,11 +243,11 @@ efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this,
>   * @buffer_size:	(required) buffer size
>   * @buffer:		buffer to which the file is to be loaded
>   */
> -efi_status_t EFIAPI load_file2(struct efi_load_file_protocol *this,
> -			       struct efi_device_path *file_path,
> -			       bool boot_policy,
> -			       efi_uintn_t *buffer_size,
> -			       void *buffer)
> +static efi_status_t EFIAPI load_file2(struct efi_load_file_protocol *this,
> +				      struct efi_device_path *file_path,
> +				      bool boot_policy,
> +				      efi_uintn_t *buffer_size,
> +				      void *buffer)
>  {
>  	++load_file2_call_count;
>  	if (memcmp(file_path, dp_lf2_file_remainder,
> -- 
> 2.34.1
> 
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>