From: Seth Forshee <sforshee@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] pnode: pass mountpoint directly
Date: Wed, 5 Apr 2023 14:30:36 -0500 [thread overview]
Message-ID: <ZC3MXAqKMyh007rV@do-x1extreme> (raw)
In-Reply-To: <20230202-fs-move-mount-replace-v2-2-f53cd31d6392@kernel.org>
On Tue, Mar 28, 2023 at 06:13:07PM +0200, Christian Brauner wrote:
> Currently, we use a global variable to stash the destination
> mountpoint. All global variables are changed in propagate_one(). The
> mountpoint variable is one of the few which doesn't change after
> initialization. Instead, just pass the destination mountpoint directly
> making it easy to verify directly in propagate_mnt() that the
> destination mountpoint never changes.
>
> Signed-off-by: Christian Brauner <brauner@kernel.org>
This doesn't seem to have anything to do with the rest of the series,
but it does make the code a little easier to follow.
Reviewed-by: Seth Forshee (DigitalOcean) <sforshee@kernel.org>
next prev parent reply other threads:[~2023-04-05 19:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 16:13 [PATCH v2 0/5] fs: allow to mount beneath top mount Christian Brauner
2023-03-28 16:13 ` [PATCH v2 1/5] fs: add path_mounted() Christian Brauner
2023-04-05 19:29 ` Seth Forshee
2023-03-28 16:13 ` [PATCH v2 2/5] pnode: pass mountpoint directly Christian Brauner
2023-04-05 19:30 ` Seth Forshee [this message]
2023-04-06 13:01 ` Christian Brauner
2023-03-28 16:13 ` [PATCH v2 3/5] fs: fix __lookup_mnt() documentation Christian Brauner
2023-04-05 19:32 ` Seth Forshee
2023-03-28 16:13 ` [PATCH v2 4/5] fs: use a for loop when locking a mount Christian Brauner
2023-04-05 19:34 ` Seth Forshee
2023-03-28 16:13 ` [PATCH v2 5/5] fs: allow to mount beneath top mount Christian Brauner
2023-03-28 22:42 ` kernel test robot
2023-04-05 19:34 ` Seth Forshee
2023-04-06 13:56 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC3MXAqKMyh007rV@do-x1extreme \
--to=sforshee@kernel.org \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.