Re: [drm-tegra:for-next 30/32] drivers/gpu/drm/tegra/fbdev.c:103:29: error: implicit declaration of function 'vmap'; did you mean 'kmap'?

[Thierry Reding <treding@nvidia.com>]

[-- Attachment #1: Type: text/plain, Size: 3245 bytes --]

On Thu, Apr 06, 2023 at 08:56:17AM +0800, kernel test robot wrote:
> Hi Thomas,
> 
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> 
> tree:   https://gitlab.freedesktop.org/drm/tegra for-next
> head:   e064bf8eeedb78439bed33990f93c7213294e005
> commit: 914cfac73e230064656a42047a6f5546ee69a14f [30/32] drm/tegra: Hide fbdev support behind config option
> config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20230406/202304060835.oYBkVjMC-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git remote add drm-tegra https://gitlab.freedesktop.org/drm/tegra
>         git fetch --no-tags drm-tegra for-next
>         git checkout 914cfac73e230064656a42047a6f5546ee69a14f
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/gpu/drm/tegra/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304060835.oYBkVjMC-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/gpu/drm/tegra/fbdev.c: In function 'tegra_fbdev_probe':
> >> drivers/gpu/drm/tegra/fbdev.c:103:29: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
>      103 |                 bo->vaddr = vmap(bo->pages, bo->num_pages, VM_MAP,
>          |                             ^~~~
>          |                             kmap
> >> drivers/gpu/drm/tegra/fbdev.c:103:60: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MTE'?
>      103 |                 bo->vaddr = vmap(bo->pages, bo->num_pages, VM_MAP,
>          |                                                            ^~~~~~
>          |                                                            VM_MTE
>    drivers/gpu/drm/tegra/fbdev.c:103:60: note: each undeclared identifier is reported only once for each function it appears in
>    drivers/gpu/drm/tegra/fbdev.c: In function 'tegra_fbdev_exit':
> >> drivers/gpu/drm/tegra/fbdev.c:186:25: error: implicit declaration of function 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
>      186 |                         vunmap(bo->vaddr);
>          |                         ^~~~~~
>          |                         kunmap
>    cc1: some warnings being treated as errors

This looks like an unfortunate interaction between this patch and
Christian's to enable compilation on !TEGRA. I think this is just a
matter of moving the linux/vmalloc.h include from fb.c to fbdev.c
because the vmap()/vunmap() calls have moved.

I'll do a MIPS allmodconfig test build to make sure this actually
fixes the problem and push out a fixed version.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]