Re: [PATCH bpf-next] selftests/bpf: Don't assume page size is 4096

[Stanislav Fomichev <sdf@google.com>]

On 03/26, Hengqi Chen wrote:
> The verifier test creates BPF ringbuf maps using hard-coded
> 4096 as max_entries. Some tests will fail if the page size
> of the running kernel is not 4096. Use getpagesize() instead.

> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>

Can you share which platform that is? The fix seems ok, but
I'm assuming that we have many more places where 4k is hardcoded :-)


> ---
>   tools/testing/selftests/bpf/test_verifier.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/tools/testing/selftests/bpf/test_verifier.c  
> b/tools/testing/selftests/bpf/test_verifier.c
> index 5b90eef09ade..e4657c5bc3f1 100644
> --- a/tools/testing/selftests/bpf/test_verifier.c
> +++ b/tools/testing/selftests/bpf/test_verifier.c
> @@ -1079,7 +1079,7 @@ static void do_test_fixup(struct bpf_test *test,  
> enum bpf_prog_type prog_type,
>   	}
>   	if (*fixup_map_ringbuf) {
>   		map_fds[20] = create_map(BPF_MAP_TYPE_RINGBUF, 0,
> -					   0, 4096);
> +					 0, getpagesize());
>   		do {
>   			prog[*fixup_map_ringbuf].imm = map_fds[20];
>   			fixup_map_ringbuf++;
> --
> 2.31.1