From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8322CA44; Tue, 28 Mar 2023 05:11:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7C66C433D2; Tue, 28 Mar 2023 05:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679980287; bh=T0M1pgvAdzRe+spfvvLVDkVSL/70Xeq1CaWoRmuHo6g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nFX55RdST9p5XWsK+lCtJ6/PsNUs1V2+T6G2aeU9AfepCCkv0U1XUxTbGxp8lxh8o irqBz+1HhFvQCqewbIAP9mbxD/KesGWfPayXiSukEnMbMICr57c0tZ8H8+TOzS0hFC 2Det/vF6EfDZ2mHH04uotEowWLXRAXeFMTkU16p4= Date: Tue, 28 Mar 2023 07:11:24 +0200 From: Greg KH To: Bagas Sanjaya Cc: Khadija Kamran , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Jerry Chuang Subject: Re: [PATCH v3 4/4] staging: rtl8192u: add '*/' on separate line in block comments Message-ID: References: <140e0928531e61dc7396271a5b16a6be17514c76.1679945728.git.kamrankhadijadj@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 28, 2023 at 10:27:32AM +0700, Bagas Sanjaya wrote: > On Tue, Mar 28, 2023 at 12:49:09AM +0500, Khadija Kamran wrote: > > Linux kernel coding style uses '*/' on a separate line at the end of > > multi line comments. > > > > Fix block comments by moving '*/' at the end of block comments on a > > separate line as reported by checkpatch.pl script. > > > > Signed-off-by: Khadija Kamran > > --- > > drivers/staging/rtl8192u/r8192U_dm.c | 21 ++++++++++++++------- > > 1 file changed, 14 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c > > index dd9903719c20..cbae852478ea 100644 > > --- a/drivers/staging/rtl8192u/r8192U_dm.c > > +++ b/drivers/staging/rtl8192u/r8192U_dm.c > > @@ -244,7 +244,8 @@ void init_rate_adaptive(struct net_device *dev) > > * Output: NONE > > * > > * Return: NONE > > - *---------------------------------------------------------------------------*/ > > + *--------------------------------------------------------------------------- > > + */ > > ... > > void dm_rf_pathcheck_workitemcallback(struct work_struct *work) > > { > > struct delayed_work *dwork = to_delayed_work(work); > > @@ -2407,7 +2413,8 @@ static void dm_rxpath_sel_byrssi(struct net_device *dev) > > * Output: NONE > > * > > * Return: NONE > > - *---------------------------------------------------------------------------*/ > > + *--------------------------------------------------------------------------- > > + */ > > While at above can you please turn these comments above into kernel-doc > comments (see Documentation/doc-guide/kernel-doc.rst for how to write > one)? This requires a placeholder doc where you can write e.g. overview > of the driver and how it is used. The doc should be in > Documentation/driver-api/staging/ (since this is staging driver). No, these are static functions, or just normal internal-to-the-driver functions, they do not need kerneldoc or any Documentation/* entries, sorry. greg k-h