Suggestions on refactoring arche_platform_wd_irq() function

[Khadija Kamran <kamrankhadijadj@gmail.com>]

Hey Outreachy Mentors,
I am working on a check reported by checkpatch.pl saying,

CHECK: line length of 101 exceeds 100 columns
#182: FILE: drivers/staging/greybus/arche-platform.c:182:
+                                                                            WD_STATE_COLDBOOT_TRIG);


To refactor the function Ira sent me a link and suggested the use of
goto statement.

Alison guided me with this problem and asked to share the diff and start
a thread for discussion. Link to Alison's mail:
https://lore.kernel.org/outreachy/ZCHPokeiKV37uOmr@aschofie-mobl2/

Kindly review the following diff:

static irqreturn_t arche_platform_wd_irq(int irq, void *devid)

        spin_lock_irqsave(&arche_pdata->wake_lock, flags);

-       if (gpiod_get_value(arche_pdata->wake_detect)) {
-               /* wake/detect rising */
-
-               /*
-                * If wake/detect line goes high after low, within less than
-                * 30msec, then standby boot sequence is initiated, which is not
-                * supported/implemented as of now. So ignore it.
-                */
-               if (arche_pdata->wake_detect_state == WD_STATE_BOOT_INIT) {
-                       if (time_before(jiffies,
-                                       arche_pdata->wake_detect_start +
-                                       msecs_to_jiffies(WD_COLDBOOT_PULSE_WIDTH_MS))) {
-                               arche_platform_set_wake_detect_state(arche_pdata,
-                                                                    WD_STATE_IDLE);
-                       } else {
-                               /*
-                                * Check we are not in middle of irq thread
-                                * already
-                                */
-                               if (arche_pdata->wake_detect_state !=
-                                               WD_STATE_COLDBOOT_START) {
-                                       arche_platform_set_wake_detect_state(arche_pdata,
-                                                                            WD_STATE_COLDBOOT_TRIG);
-                                       spin_unlock_irqrestore(&arche_pdata->wake_lock,
-                                                              flags);
-                                       return IRQ_WAKE_THREAD;
-                               }
-                       }
-               }
-       } else {
+       if (!gpiod_get_value(arche_pdata->wake_detect)) {
                /* wake/detect falling */
-               if (arche_pdata->wake_detect_state == WD_STATE_IDLE) {
-                       arche_pdata->wake_detect_start = jiffies;
+               goto falling;
+       }
+
+       /* wake/detect rising */
+
+       /*
+        * If wake/detect line goes high after low, within less than
+        * 30msec, then standby boot sequence is initiated, which is not
+        * supported/implemented as of now. So ignore it.
+        */
+       if (arche_pdata->wake_detect_state == WD_STATE_BOOT_INIT) {
+               if (time_before(jiffies,
+                               arche_pdata->wake_detect_start +
+                               msecs_to_jiffies(WD_COLDBOOT_PULSE_WIDTH_MS))) {
+                       arche_platform_set_wake_detect_state(arche_pdata,
+                                                            WD_STATE_IDLE);
+               } else {
                        /*
-                        * In the beginning, when wake/detect goes low
-                        * (first time), we assume it is meant for coldboot
-                        * and set the flag. If wake/detect line stays low
-                        * beyond 30msec, then it is coldboot else fallback
-                        * to standby boot.
+                        * Check we are not in middle of irq thread
+                        * already
                         */
-                       arche_platform_set_wake_detect_state(arche_pdata,
-                                                            WD_STATE_BOOT_INIT);
+                       if (arche_pdata->wake_detect_state !=
+                                       WD_STATE_COLDBOOT_START) {
+                               arche_platform_set_wake_detect_state(arche_pdata,
+                                                                    WD_STATE_COLDBOOT_TRIG);
+                               spin_unlock_irqrestore(&arche_pdata->wake_lock,
+                                                      flags);
+                               return IRQ_WAKE_THREAD;
+                       }
                }
+               goto out;
        }

+falling:
+       if (arche_pdata->wake_detect_state == WD_STATE_IDLE) {
+               arche_pdata->wake_detect_start = jiffies;
+               /*
+                * In the beginning, when wake/detect goes low
+                * (first time), we assume it is meant for coldboot
+                * and set the flag. If wake/detect line stays low
+                * beyond 30msec, then it is coldboot else fallback
+                * to standby boot.
+                */
+               arche_platform_set_wake_detect_state(arche_pdata,
+                                                    WD_STATE_BOOT_INIT);
+
+out:
        spin_unlock_irqrestore(&arche_pdata->wake_lock, flags);

        return IRQ_HANDLED;

Thank you!

Regards,
Khadija