From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B9DC77B6C for ; Wed, 29 Mar 2023 08:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231217AbjC2IWz (ORCPT ); Wed, 29 Mar 2023 04:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231183AbjC2IW1 (ORCPT ); Wed, 29 Mar 2023 04:22:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C47C46A3 for ; Wed, 29 Mar 2023 01:21:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFD1161B01 for ; Wed, 29 Mar 2023 08:21:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF050C433D2; Wed, 29 Mar 2023 08:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680078098; bh=B3poQQAEQoaoNAAiBY1IBWWvJkKFcy/RxvvMNeAwWqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2YpjBC8s4Czv7ne9DwnzXn9KhMWmEKbOxZ5sv7lEtJqvWHfj6ELrkSrFYjosBD2bK NOtFRlVRqELylvzK+QZa8l8ryljdF2vxlAe5J0ARoG67yktF/+dZKMnvwm7nO//hIa +BjI5Xk50YFEefCOe3QXf98sd+/ZNz0WbrNmF0L0= Date: Wed, 29 Mar 2023 10:21:35 +0200 From: Greg Kroah-Hartman To: Linyu Yuan Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH v3 6/6] usb: gadget: f_fs: show instance name in debug message Message-ID: References: <1679911940-4727-1-git-send-email-quic_linyyuan@quicinc.com> <1679911940-4727-6-git-send-email-quic_linyyuan@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Mar 29, 2023 at 03:42:08PM +0800, Linyu Yuan wrote: > > On 3/29/2023 3:37 PM, Greg Kroah-Hartman wrote: > > On Wed, Mar 29, 2023 at 03:11:14PM +0800, Linyu Yuan wrote: > > > On 3/29/2023 2:54 PM, Greg Kroah-Hartman wrote: > > > > On Mon, Mar 27, 2023 at 06:12:20PM +0800, Linyu Yuan wrote: > > > > > show ffs->dev_name in all possible debug message. > > > > > > > > > > Signed-off-by: Linyu Yuan > > > > > --- > > > > > v3: change according comments > > > > > v2: split to several changes according to v1 comments > > > > > v1: https://lore.kernel.org/linux-usb/1679481369-30094-1-git-send-email-quic_linyyuan@quicinc.com/ > > > > > > > > > > drivers/usb/gadget/function/f_fs.c | 141 ++++++++++++++++++++----------------- > > > > > 1 file changed, 75 insertions(+), 66 deletions(-) > > > > > > > > > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > > > > > index 0761eaa..383343d 100644 > > > > > --- a/drivers/usb/gadget/function/f_fs.c > > > > > +++ b/drivers/usb/gadget/function/f_fs.c > > > > > @@ -317,12 +317,12 @@ static int __ffs_ep0_queue_wait(struct ffs_data *ffs, char *data, size_t len) > > > > > static int __ffs_ep0_stall(struct ffs_data *ffs) > > > > > { > > > > > if (ffs->ev.can_stall) { > > > > > - dev_vdbg(ffs->dev, "ep0 stall\n"); > > > > > + dev_vdbg(ffs->dev, "%s: ep0 stall\n", ffs->dev_name); > > > > You already have the name here, it's in the usb-gadget structure, why do > > > > you need to print it out again? > > > > > > > > What is the before and after output of this change? I think it should > > > > have the same information already in it. > > > > > > you have wrong understanding of usb_gadget->dev and ffs->dev_name, > > > > > > this is output example, > > > > > > [11.046519] configfs-gadget.g1 gadget.0: adb: interface descriptor > > > > > > usb_gadget->dev is gadget.0, > > > > > > but ffs->dev_name is adb. > > Isn't there some mapping of gadget name to "dev_name" somewhere else in > > the logs? And what sets dev_name, why isn't that part of the gadget > > name already? > > > ffs->dev_name should be different from gadget name, > > as we can create multiple ffs instances (adb, MTP, PTP ...) which work on > one gadget device (gadget.0). Shouldn't all of those instances have their own struct device pointer? thanks, greg k-h